Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicsCompressorNode - remove page macro #4857

Merged
merged 1 commit into from
May 18, 2021

Conversation

hamishwillee
Copy link
Collaborator

This is part of fixing #3196

DynamicsCompressorNode and it's properties were importing the example from BaseAudioContext.createDynamicsCompressor using the page macro.

This replaces that with the information from the syntax section + a link to the example (the syntax section has a minimal usage). Note that there is discussion ongoing about whether the syntax section should be removed for properties.

@hamishwillee hamishwillee requested a review from a team as a code owner May 10, 2021 05:21
@hamishwillee hamishwillee requested review from Rumyra and removed request for a team May 10, 2021 05:21
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/DynamicsCompressorNode
Title: DynamicsCompressorNode
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist

URL: /en-US/docs/Web/API/DynamicsCompressorNode/attack
Title: DynamicsCompressorNode.attack
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist

URL: /en-US/docs/Web/API/DynamicsCompressorNode/reduction
Title: DynamicsCompressorNode.reduction
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist

URL: /en-US/docs/Web/API/DynamicsCompressorNode/knee
Title: DynamicsCompressorNode.knee
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist

URL: /en-US/docs/Web/API/DynamicsCompressorNode/DynamicsCompressorNode
Title: DynamicsCompressorNode()
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist

URL: /en-US/docs/Web/API/DynamicsCompressorNode/threshold
Title: DynamicsCompressorNode.threshold
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist

URL: /en-US/docs/Web/API/DynamicsCompressorNode/ratio
Title: DynamicsCompressorNode.ratio
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist

URL: /en-US/docs/Web/API/DynamicsCompressorNode/release
Title: DynamicsCompressorNode.release
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist

External URLs

URL: /en-US/docs/Web/API/BaseAudioContext/createDynamicsCompressor
Title: BaseAudioContext.createDynamicsCompressor()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DynamicsCompressorNode
Title: DynamicsCompressorNode
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DynamicsCompressorNode/attack
Title: DynamicsCompressorNode.attack
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DynamicsCompressorNode/reduction
Title: DynamicsCompressorNode.reduction
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DynamicsCompressorNode/knee
Title: DynamicsCompressorNode.knee
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DynamicsCompressorNode/DynamicsCompressorNode
Title: DynamicsCompressorNode()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DynamicsCompressorNode/threshold
Title: DynamicsCompressorNode.threshold
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DynamicsCompressorNode/ratio
Title: DynamicsCompressorNode.ratio
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DynamicsCompressorNode/release
Title: DynamicsCompressorNode.release
on GitHub

No new external URLs

Copy link
Collaborator

@Rumyra Rumyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@Rumyra Rumyra merged commit 8ac5078 into mdn:main May 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants