-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamicsCompressorNode - remove page macro #4857
DynamicsCompressorNode - remove page macro #4857
Conversation
Preview URLs
FlawsNote! 1 document with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
This is part of fixing #3196
DynamicsCompressorNode and it's properties were importing the example from BaseAudioContext.createDynamicsCompressor using the page macro.
This replaces that with the information from the syntax section + a link to the example (the syntax section has a minimal usage). Note that there is discussion ongoing about whether the syntax section should be removed for properties.