Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix ChildNode.remove to Element, CharacterData, DocumentType #5088

Merged
merged 2 commits into from
May 21, 2021

Conversation

@Elchi3 Elchi3 requested a review from a team as a code owner May 18, 2021 12:29
@Elchi3 Elchi3 requested a review from a team May 18, 2021 12:29
@Elchi3 Elchi3 requested a review from a team as a code owner May 18, 2021 12:29
@Elchi3 Elchi3 requested review from chrisdavidmills and removed request for a team May 18, 2021 12:29
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but nothing much. Nice work @Elchi3 !

files/en-us/_redirects.txt Show resolved Hide resolved
files/en-us/web/api/characterdata/remove/index.html Outdated Show resolved Hide resolved
files/en-us/web/api/documenttype/remove/index.html Outdated Show resolved Hide resolved
---
<div>{{APIRef("DOM")}}</div>

<p>The <code><strong>DocumentType.remove()</strong></code> method removes a document's <code>doctype</code>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you ever want to do this? I do wonder if it's possible to add a line or two describing why you might want to do this, if such information is available.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why anyone wants to do it, but if it is because of getting to quirks mode, I've added a note to the doc saying that this is a bad idea.

files/en-us/web/api/element/remove/index.html Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2021

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn/JavaScript/Client-side_web_APIs/Manipulating_documents
Title: Manipulating documents
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Web/API/CharacterData
Title: CharacterData
on GitHub
Flaw count: 2

  • bad_bcd_links:
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/CharacterData/remove
Title: CharacterData.remove()
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.CharacterData.remove

URL: /en-US/docs/Web/API/Element
Title: Element
on GitHub
Flaw count: 5

  • macros:
    • /en-us/docs/web/api/parentnode (url: /en-US/docs/Web/API/ParentNode) does not exist
    • /en-us/docs/web/api/animatable (url: /en-US/docs/Web/API/Animatable) does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onshow does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/Element/remove
Title: Element.remove()
on GitHub
Flaw count: 3

  • macros:
    • /en-us/docs/web/api/parentnode (url: /en-US/docs/Web/API/ParentNode) does not exist
    • /en-us/docs/web/api/animatable (url: /en-US/docs/Web/API/Animatable) does not exist
  • bad_bcd_queries:
    • No BCD data for query: api.Element.remove

URL: /en-US/docs/Web/API/DocumentType
Title: DocumentType
on GitHub
Flaw count: 16

  • macros:
    • /en-US/docs/Web/API/DocumentType/entities does not exist
    • /en-US/docs/Web/API/Entity does not exist
    • /en-US/docs/Web/API/DocumentType/internalSubset does not exist
    • /en-US/docs/Web/API/DocumentType/name does not exist
    • /en-US/docs/Web/API/DocumentType/notations does not exist
    • and 5 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/DocumentType/remove
Title: DocumentType.remove()
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.DocumentType.remove

External URLs

URL: /en-US/docs/Learn/JavaScript/Client-side_web_APIs/Manipulating_documents
Title: Manipulating documents
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/CharacterData
Title: CharacterData
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/CharacterData/remove
Title: CharacterData.remove()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Element
Title: Element
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Element/remove
Title: Element.remove()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLSelectElement/remove
Title: HTMLSelectElement.remove()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Node/removeChild
Title: Node.removeChild()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DocumentType
Title: DocumentType
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DocumentType/remove
Title: DocumentType.remove()
on GitHub

No new external URLs

(this comment was updated 2021-05-19 14:05:46.620797)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looking good to go. Nice one @Elchi3 !

@chrisdavidmills chrisdavidmills merged commit c198b05 into mdn:main May 21, 2021
@Elchi3 Elchi3 deleted the demix-childnode-remove branch May 21, 2021 08:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants