AudioNode.ChannelInterpretation: remove page macro #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
commented
May 24, 2021
| @@ -311,13 +311,13 @@ <h2 id="Visualizations">Visualizations</h2> | |||
|
|
|||
| <dl> | |||
| <dt>{{domxref("AnalyserNode.getFloatFrequencyData()")}}</dt> | |||
| <dd>Copies the current frequency data into a {{domxref("Float32Array")}} array passed into it.</dd> | |||
| <dd>Copies the current frequency data into a {{jsxref("Float32Array")}} array passed into it.</dd> | |||
There was a problem hiding this comment.
FYI these are just macro flaw fixes
Preview URLs
FlawsNone! 🎉 External URLsURL: No new external URLs URL: No new external URLs |
hamishwillee
commented
May 24, 2021
| <dt><code>speakers</code></dt> | ||
| <dd>Use set of "standard" mappings for combinations of common speaker input and outputs setups (mono, stereo, quad, 5.1). For example, with this setting a mono channel input will output to both channels of a stereo output.</dd> | ||
| <dt><code>discrete</code></dt> | ||
| <dd>Input channels are mapped to output channels in order. If there are more inputs that outputs the additional inputs are dropped; if there are fewer then the unused outputs are silent.</dd> |
There was a problem hiding this comment.
This is what the spec says, but I am not clear what it actually means. So for example, Imagine I have a stereo input and a 5.1 output. I understand that two of the inputs will be mapped to two of the outputs and the rest will be silent.
But, which two outputs? How are outputs and inputs numbered?
sideshowbarker
approved these changes
May 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix to #3196
AudioNode.ChannelInterpretation was pulling in the table of values for that method from https://developer.mozilla.org/en-US/docs/Web/API/Web_Audio_API/Basic_concepts_behind_Web_Audio_API#up-mixing_and_down-mixing
Again, the values would be useful alongside this method. However not worth including. What I have done though is improved the description here/summary of what the values actually mean because without the table the description is insufficient.
I also took the time to link to BCD for the compatibility table and spec.