Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioWorkletProcessor.parameterDescriptors remove Page macro from example #5239

Merged
merged 1 commit into from
May 25, 2021

Conversation

hamishwillee
Copy link
Collaborator

Partial fix to #3196

Removes Page macro from AudioWorkletProcessor.parameterDescriptors static getter example, replacing it with a link to the example.
This is pretty much the agreed approach for removing the Page macro from examples.

This also adds BCD to page frontmatter on affected pages, fixing up compat and spec tables as appropriate.

@hamishwillee hamishwillee requested a review from a team as a code owner May 24, 2021 05:48
@hamishwillee hamishwillee requested review from jpmedley and wbamberg and removed request for a team May 24, 2021 05:48
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/AudioWorkletProcessor/parameterDescriptors
Title: AudioWorkletProcessor.parameterDescriptors (static getter)
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.AudioWorkletProcessor.parameterDescriptors

External URLs

URL: /en-US/docs/Web/API/AudioWorkletNode/parameters
Title: AudioWorkletNode.parameters
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/AudioWorkletProcessor/parameterDescriptors
Title: AudioWorkletProcessor.parameterDescriptors (static getter)
on GitHub

No new external URLs

@hamishwillee
Copy link
Collaborator Author

@chrisdavidmills Could you please look at this one?

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good one in the bag; thanks @hamishwillee

@chrisdavidmills chrisdavidmills merged commit 0cd2d5a into mdn:main May 25, 2021
@hamishwillee hamishwillee deleted the audioworknode_pagemacro branch May 25, 2021 23:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants