chore: remove index.html support #7575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
force-pushed
the
remove-index-html-support
branch
from
803c043
to
53def3d
Compare
|
The how it works section of the readme will also need some updating. |
caugner
force-pushed
the
remove-index-html-support
branch
from
94dd3cd
to
397f491
Compare
caugner
commented
Nov 16, 2022
There was a problem hiding this comment.
Test failure (see here):
Error: MacroLiveSampleError within /home/runner/work/yari/yari/testing/content/files/en-us/learn/css/css_layout/introduction/flex/index.md, line 19 column 1 (unable to find any live code samples for "flex_1" within /en-US/docs/Learn/CSS/CSS_layout/Introduction/Flex)
at buildDocument (/home/runner/work/yari/yari/build/index.ts:369:17)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async buildDocumentInteractive (/home/runner/work/yari/yari/build/cli.ts:61:29)
at async buildDocuments (/home/runner/work/yari/yari/build/cli.ts:156:20)
at async Se._action (/home/runner/work/yari/yari/build/cli.ts:445:60)
at async Se.run (/home/runner/work/yari/yari/node_modules/@caporal/core/dist/index.js:1:27579)
error: MacroLiveSampleError within /home/runner/work/yari/yari/testing/content/files/en-us/learn/css/css_layout/introduction/flex/index.md, line 19 column 1 (unable to find any live code samples for "flex_1" within /en-US/docs/Learn/CSS/CSS_layout/Introduction/Flex)
at async Te._run (/home/runner/work/yari/yari/node_modules/@caporal/core/dist/index.js:1:32257)
github-actions
bot
added
deployer
|
Hi @caugner, should we modify the testing documents. For there are no {{page}} macro left in en-US (maybe we should deprecate See mdn/content#3196.
|
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
caugner
force-pushed
the
remove-index-html-support
branch
from
ad2891e
to
3930a98
Compare
github-actions
bot
removed
the
merge conflicts 🚧
Using mdn/markdown, ran `yarn m2h`.
Some flaws do not seem to support Markdown: - bad_pre - images - sectioning - (possibly others)
caugner
force-pushed
the
remove-index-html-support
branch
from
3930a98
to
f17e713
Compare
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
Closing, as the build system is currently being rewritten, which will also fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7574.
Problem
We are now 100% Markdown i.e. all content (and translated-content) is using
index.mdexclusively, but yari still supportsindex.html.Solution
Remove support for content in
index.htmlfiles.Screenshots
n/a
How did you test this change?