-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove volumeAttachment deletion #102
Conversation
VA should not be deleted by FAR. The kube-control-manager (KCM) detects the pod deletion and automatically detaches the Volume Attachments (VAs) that are not connected to any pod, forcefully deleting the VA has the risk of interfering with the process of detaching the VAs.
PodDeletion has moved to common so SNR and FAR used the same resource deletion
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
@mshitrit: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 4.12-openshift-e2e |
1 similar comment
/test 4.12-openshift-e2e |
/lgtm |
The kube-control-manager (KCM) detects the pod deletion and automatically detaches the Volume Attachments (VAs) that are not connected to any pod, forcefully deleting the VA has the risk of interfering with the process of detaching the VAs.
Therefore, FAR should not delete any volume attachments as part of deleting the resources, except pods deletion. Similar to SNR's PR.
ECOPROJECT-1754