Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove volumeAttachment deletion #102

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Nov 5, 2023

The kube-control-manager (KCM) detects the pod deletion and automatically detaches the Volume Attachments (VAs) that are not connected to any pod, forcefully deleting the VA has the risk of interfering with the process of detaching the VAs.

Therefore, FAR should not delete any volume attachments as part of deleting the resources, except pods deletion. Similar to SNR's PR.

ECOPROJECT-1754

VA should not be deleted by FAR. The kube-control-manager (KCM) detects the pod deletion and automatically detaches the Volume Attachments (VAs) that are not connected to any pod, forcefully deleting the VA has the risk of interfering with the process of detaching the VAs.
PodDeletion has moved to common so SNR and FAR used the same resource deletion
Copy link
Contributor

openshift-ci bot commented Nov 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Nov 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 5, 2023
@mshitrit
Copy link
Member

mshitrit commented Nov 5, 2023

/test ?

Copy link
Contributor

openshift-ci bot commented Nov 5, 2023

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.12-ci-bundle-my-bundle
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.12-test
  • /test 4.13-ci-bundle-my-bundle
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.13-test
  • /test 4.14-ci-bundle-my-bundle
  • /test 4.14-images
  • /test 4.14-openshift-e2e
  • /test 4.14-test
  • /test 4.15-ci-bundle-my-bundle
  • /test 4.15-images
  • /test 4.15-openshift-e2e
  • /test 4.15-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Member

mshitrit commented Nov 5, 2023

/test 4.12-openshift-e2e

1 similar comment
@razo7
Copy link
Member Author

razo7 commented Nov 6, 2023

/test 4.12-openshift-e2e

@slintes
Copy link
Member

slintes commented Nov 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 6, 2023
@razo7 razo7 marked this pull request as ready for review November 6, 2023 09:06
@openshift-ci openshift-ci bot merged commit 020b8ca into medik8s:main Nov 6, 2023
18 checks passed
@slintes slintes mentioned this pull request Nov 8, 2023
4 tasks
@razo7 razo7 deleted the no-va-deletion branch January 7, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants