-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant VoulmeAttachment from testing #144
Conversation
Skipping CI for Draft Pull Request. |
/test ci/prow/4.16-openshift-e2e |
@razo7: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 4.16-openshift-e2e |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/hold |
/unhold |
tide job is not responding, so I am pushing old commit as a new one to retrigger tide (with the many other tests)... |
VoulmeAttachment is no longer removed by resource deletion strategy, thus it is no longer needed for testing
/retest |
/lgtm |
/retest |
1 similar comment
/retest |
/hold need to fix CI config for having e2e tests required |
/hold cancel |
/test 4.17-ci-bundle-my-bundle |
/retest |
1 similar comment
/retest |
/test 4.13-openshift-e2e |
Why we need this PR
VoulmeAttachment is no longer removed from the resource deletion strategy, thus it is no longer needed for testing. Follow up to #102 .
Changes made
Remove VoulmeAttachment creation and deletion in unit-test.
Which issue(s) this PR fixes
Test plan