Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant VoulmeAttachment from testing #144

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Apr 17, 2024

Why we need this PR

VoulmeAttachment is no longer removed from the resource deletion strategy, thus it is no longer needed for testing. Follow up to #102 .

Changes made

Remove VoulmeAttachment creation and deletion in unit-test.

Which issue(s) this PR fixes

Test plan

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@razo7
Copy link
Member Author

razo7 commented Apr 17, 2024

/test ci/prow/4.16-openshift-e2e

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

@razo7: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test 4.12-ci-bundle-my-bundle
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.12-test
  • /test 4.13-ci-bundle-my-bundle
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.13-test
  • /test 4.14-ci-bundle-my-bundle
  • /test 4.14-images
  • /test 4.14-openshift-e2e
  • /test 4.14-test
  • /test 4.15-ci-bundle-my-bundle
  • /test 4.15-images
  • /test 4.15-openshift-e2e
  • /test 4.15-test
  • /test 4.16-ci-bundle-my-bundle
  • /test 4.16-images
  • /test 4.16-openshift-e2e
  • /test 4.16-test

Use /test all to run all jobs.

In response to this:

/test ci/prow/4.16-openshift-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@razo7
Copy link
Member Author

razo7 commented Apr 17, 2024

/test 4.16-openshift-e2e

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 marked this pull request as ready for review April 17, 2024 14:47
@openshift-ci openshift-ci bot requested review from beekhof and clobrano April 17, 2024 14:47
@razo7
Copy link
Member Author

razo7 commented Apr 17, 2024

/retest

1 similar comment
@razo7
Copy link
Member Author

razo7 commented Apr 17, 2024

/retest

@razo7
Copy link
Member Author

razo7 commented Apr 18, 2024

/hold
Waiting for #92 to be merged first

@razo7
Copy link
Member Author

razo7 commented Apr 28, 2024

/unhold

@razo7
Copy link
Member Author

razo7 commented Apr 30, 2024

tide job is not responding, so I am pushing old commit as a new one to retrigger tide (with the many other tests)...

VoulmeAttachment is no longer removed by resource deletion strategy, thus it is no longer needed for testing
@razo7
Copy link
Member Author

razo7 commented May 1, 2024

/retest

@slintes
Copy link
Member

slintes commented May 2, 2024

/lgtm

@slintes
Copy link
Member

slintes commented Jul 1, 2024

/retest

1 similar comment
@slintes
Copy link
Member

slintes commented Jul 1, 2024

/retest

@slintes
Copy link
Member

slintes commented Jul 1, 2024

/hold

need to fix CI config for having e2e tests required

@slintes
Copy link
Member

slintes commented Jul 1, 2024

/hold cancel

@slintes
Copy link
Member

slintes commented Jul 1, 2024

/test 4.17-ci-bundle-my-bundle

@razo7
Copy link
Member Author

razo7 commented Jul 2, 2024

/retest

1 similar comment
@slintes
Copy link
Member

slintes commented Jul 25, 2024

/retest

@slintes
Copy link
Member

slintes commented Jul 25, 2024

/test 4.13-openshift-e2e
/test 4.15-openshift-e2e

@openshift-merge-bot openshift-merge-bot bot merged commit ae0561c into medik8s:main Jul 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants