Align FAR CRDs to NHC #16
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
razo7
force-pushed
the
align-far-to-nhc
branch
2 times, most recently
from
bde73aa
to
dabc652
Compare
|
Github CI has failed and #17 should resolve it. |
| } | ||
|
|
||
| func (r *FenceAgentsRemediationReconciler) getFAPod(namespace string) (*corev1.Pod, error) { | ||
| // getFenceAgentsPod fetches the FAR pod based on FAR's label and namespace | ||
| func (r *FenceAgentsRemediationReconciler) getFenceAgentsPod(namespace string) (*corev1.Pod, error) { |
There was a problem hiding this comment.
something for a follow up, not this PR: you don't need to search the pod, you can know its namespace and name, see here for how to get the namespace, same should work for the name: https://github.com/medik8s/node-healthcheck-operator/blob/main/config/manager/manager.yaml#L53
There was a problem hiding this comment.
Good point, and it sounds like a better coding
razo7
force-pushed
the
align-far-to-nhc
branch
from
dabc652
to
7cb081b
Compare
Align FARTemplete Spec with expected remediator spec for NHC
We need Role aggregation that will give NHC/MHC access to the template and remediation CRs with a special label
Due to CRDs changes the reconcile must be updated
razo7
force-pushed
the
align-far-to-nhc
branch
from
7cb081b
to
824bb31
Compare
Due to CRDs changes the CRD examples should be updated
Include CRD's resources in CSV
|
I would have felt a lot better if we had some unit tests to verify this kind of a change, but I guess in this case it's an egg and chicken scenario 🙂 |
FAR's CRDs didn't follow the motivation/desgin of the other remediators (e.g. MDRTemplate Spec) - remediator should have template field under Spec. This PR should align FAR CRDs to NHC/MHC expectations
FenceAgentsRemediationSpectype).