Add operator-sdk annotations - FAR resources #18
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
go.mod
Outdated
| @@ -6,6 +6,7 @@ require ( | |||
| github.com/go-logr/logr v1.2.0 | |||
| github.com/onsi/ginkgo v1.16.5 | |||
| github.com/onsi/gomega v1.17.0 | |||
| go.uber.org/zap v1.19.1 | |||
There was a problem hiding this comment.
this change doesn't make sense in the context of this PR?
There was a problem hiding this comment.
It's unrelated.
Running make go-verify does this change.
I didn't thought it's worth a PR but I can append this change to another PR if you prefer to.
There was a problem hiding this comment.
CI complains about the modified go.mod as well, so something is wrong, either the file, or CI. Check the make targets, order matters sometimes 🤷🏼♂️ (e.g. make generate and go fmt / goimports sometimes have slightly different output with import aliases)
There was a problem hiding this comment.
For me go mod tidy did the trick and reveled the changes
There was a problem hiding this comment.
I locally use Golang version 1.20. Maybe it matters
There was a problem hiding this comment.
It matters, always use the same (x.y at least) version locally.
I use https://github.com/travis-ci/gimme for quickly switching versions.
There was a problem hiding this comment.
Nice, I will give it a try. I will add the above change when I will update FAR to Golang v1.20 👍🏻
Include CRD's resources in CSV - customresourcedefinitions
|
/lgtm |
Include CRD's resources in CSV - customresourcedefinitions.
Follow up to commit and discussion.