Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang to v1.18 #25

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Mar 20, 2023

  • Set Golang v1.18 in go.mod
  • Set up Golang in Pre Submit Github Action and using go.mod and go.sum files to check and verify the Golang version

Newer Golang version
Add missing and remove unused modules, make vendored copy of dependencies, and verify dependencies have expected content
Needed for running `test` target and use go.mod and go.sum files
@openshift-ci openshift-ci bot requested review from beekhof and mshitrit March 20, 2023 09:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 mentioned this pull request Mar 20, 2023
@mshitrit
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2023
@openshift-merge-robot openshift-merge-robot merged commit f9746a4 into medik8s:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants