Update Tools and API Versions #56

razo7 · 2023-06-12T06:14:38Z

Bump FAR to the latest tool and API versions (e.g. K8s, OCP, Controller-gen, Kustomize, and Operator-SDK).

In addition it also includes more stuff:

Fix for writing/deleting the envtest target directory
Fetching the machine client (for E2E) using OpenShift client-go

ECOPROJECT-1403

razo7 · 2023-06-12T06:43:11Z

Golang must be v1.20 prior to merging this PR.
/hold
Wait for #57 to be merged

razo7 · 2023-06-14T08:19:57Z

E2E test will fail as it needs openshift/release#40248 to be merged, so Golang version on E2E will be updated

razo7 · 2023-06-14T11:48:35Z

/retest

mshitrit · 2023-06-15T06:35:17Z

/lgtm
/hold
Giving others chance to review

clobrano · 2023-06-15T08:55:39Z

/lgtm

Giving a chance to get more feedbacks, feel free to unhold
/hold

razo7 · 2023-06-25T12:24:35Z

I hope #20 will be merged soon, and I prefer to wait for this PR to be merged. Since the current PR introduce huge bump (by time of versions, and not necessarily of FAR's functionality), thus I would prefer to wait for #20.

razo7 · 2023-06-28T11:30:44Z

/retest

razo7 · 2023-06-28T11:31:20Z

E2E PR was merged and this PR is ready for review

slintes

there changes not relevant to the PR title in the PR

please revert the kustomize changes and put them in into their own PR. And when doing so, either delete all unneeded and/or commented configs, or migrate all of them to the new format. What we have in this PR now is a mix of everything. I'd prefer to migrate all (and keep them commented), it will make enabling webhooks later on much easier
there are also code changes, probably also worth their own PR?

slintes · 2023-06-28T16:04:14Z

bundle/manifests/fence-agents-remediation.medik8s.io_fenceagentsremediations.yaml

@@ -73,5 +73,5 @@ status:
  acceptedNames:
    kind: ""
    plural: ""
-  conditions: []
-  storedVersions: []
+  conditions: null


interesting... in /config this status is removed completely from the CRDs, here just the list values change 🤔 🤷

slintes · 2023-06-28T16:05:35Z

config/crd/kustomization.yaml

@@ -6,7 +6,6 @@ resources:
 - bases/fence-agents-remediation.medik8s.io_fenceagentsremediationtemplates.yaml
 #+kubebuilder:scaffold:crdkustomizeresource

-patchesStrategicMerge:


so... how would we enable webhooks now?

slintes · 2023-06-28T16:07:10Z

config/default/kustomization.yaml

@@ -45,31 +37,15 @@ patchesStrategicMerge:
 #- webhookcainjection_patch.yaml

 # the following config is for teaching kustomize how to do var substitution
-vars:
-# [CERTMANAGER] To enable cert-manager, uncomment all sections with 'CERTMANAGER' prefix.


not sure if it's a good idea to remove this certmanager config...

razo7 · 2023-06-29T05:53:14Z

Ok, I will create PR for changing the OCP client-go and fetching machine client in E2E test and in another PR I will update and fix deprecation warnings due to Kustomize v5 changes.

migrate all of them to the new format.

When you say new format are you referring to Kubebuilder go/v3 to g0/v4? I remembered that go/v4 was still as alpha, and looking again I see that it has already been stabilized ECOPROJECT-1315

There are newer versions & reorganize the tool order as their targets order

There was no write permission, thus go-install-tool couldn't remove the old directory

razo7 · 2023-06-29T07:14:28Z

there are also code changes, probably also worth their own PR?

I was thinking of doing another PR for them.

Ok, I will create PR for changing the OCP client-go and fetching machine client in E2E test

But looking again on the changes, they are quite minor IMHO, and due to bumping the K8s and OCP APIs I was aware of an error with vet under vendor due to the old github.com/openshift/machine-api-operator package.
Therefore, I would prefer to let the these code changes remain in this PR.
I can update the PR's title if you still see a need for that.
WDYT?

slintes · 2023-06-29T09:23:59Z

there are also code changes, probably also worth their own PR?

I was thinking of doing another PR for them.

Ok, I will create PR for changing the OCP client-go and fetching machine client in E2E test

But looking again on the changes, they are quite minor IMHO, and due to bumping the K8s and OCP APIs I was aware of an error with vet under vendor due to the old github.com/openshift/machine-api-operator package. Therefore, I would prefer to let the these code changes remain in this PR. I can update the PR's title if you still see a need for that. WDYT?

ack, wfm

Use Kubernetes v1.27, and OCP v4.14 (go get -u github.com/openshift/[email protected])

github.com/openshift/machine-api-operator pacakge was outdated, thus we use the OCP client-go package

Add missing and remove unused modules, make vendored copy of dependencies, and verify dependencies have expected content

Update /bundle directory

razo7 · 2023-06-29T09:52:31Z

Updating to kustomize v5, and removing new deprecation warnings will be done in a follow up PR when we change the project layout to go/v4 - ECOPROJECT-1315

razo7 · 2023-06-29T10:35:37Z

/unhold

openshift-ci · 2023-07-03T11:36:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [razo7,slintes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from beekhof and slintes June 12, 2023 06:15

openshift-ci bot added the approved label Jun 12, 2023

openshift-ci bot added the do-not-merge/hold label Jun 12, 2023

razo7 force-pushed the update-tools-v0.1.0+ branch 3 times, most recently from f1c58a0 to 144013d Compare June 14, 2023 08:18

razo7 changed the title ~~Update Tool and API Versions~~ Update Tools and API Versions Jun 15, 2023

openshift-ci bot assigned mshitrit Jun 15, 2023

openshift-ci bot added the lgtm label Jun 15, 2023

openshift-ci bot assigned clobrano Jun 15, 2023

razo7 force-pushed the update-tools-v0.1.0+ branch from 144013d to 8248174 Compare June 28, 2023 06:30

openshift-ci bot removed the lgtm label Jun 28, 2023

slintes requested changes Jun 28, 2023

View reviewed changes

openshift-ci bot assigned slintes Jun 28, 2023

razo7 added 2 commits June 29, 2023 09:06

Update tools versions

1348b0b

There are newer versions & reorganize the tool order as their targets order

Add write/delete permissions for envtest target

5b05d33

There was no write permission, thus go-install-tool couldn't remove the old directory

razo7 added 2 commits June 29, 2023 12:41

Update Kubernetes and OpenShift pacakages

749355c

Use Kubernetes v1.27, and OCP v4.14 (go get -u github.com/openshift/[email protected])

Use OCP client-go for fetching machine client

0565d41

github.com/openshift/machine-api-operator pacakge was outdated, thus we use the OCP client-go package

razo7 added 2 commits June 29, 2023 12:43

Run make go-verify

49a35cc

Add missing and remove unused modules, make vendored copy of dependencies, and verify dependencies have expected content

Apply controller-gen and Operator-sdk changes

a745ec7

Update /bundle directory

razo7 force-pushed the update-tools-v0.1.0+ branch from 5598047 to a745ec7 Compare June 29, 2023 09:46

razo7 mentioned this pull request Jun 29, 2023

Validate utils Package and Taint Functionality #61

Merged

openshift-ci bot removed the do-not-merge/hold label Jun 29, 2023

slintes approved these changes Jul 3, 2023

View reviewed changes

openshift-ci bot added the lgtm label Jul 3, 2023

openshift-merge-robot merged commit 50ea936 into medik8s:main Jul 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Tools and API Versions #56

Update Tools and API Versions #56

razo7 commented Jun 12, 2023 •

edited

Loading

razo7 commented Jun 12, 2023

razo7 commented Jun 14, 2023

razo7 commented Jun 14, 2023

mshitrit commented Jun 15, 2023

clobrano commented Jun 15, 2023

razo7 commented Jun 25, 2023 •

edited

Loading

razo7 commented Jun 28, 2023

razo7 commented Jun 28, 2023

slintes left a comment •

edited

Loading

slintes Jun 28, 2023

slintes Jun 28, 2023

slintes Jun 28, 2023

razo7 commented Jun 29, 2023 •

edited by openshift-ci bot

Loading

razo7 commented Jun 29, 2023

slintes commented Jun 29, 2023

razo7 commented Jun 29, 2023

razo7 commented Jun 29, 2023

openshift-ci bot commented Jul 3, 2023

Update Tools and API Versions #56

Update Tools and API Versions #56

Conversation

razo7 commented Jun 12, 2023 • edited Loading

razo7 commented Jun 12, 2023

razo7 commented Jun 14, 2023

razo7 commented Jun 14, 2023

mshitrit commented Jun 15, 2023

clobrano commented Jun 15, 2023

razo7 commented Jun 25, 2023 • edited Loading

razo7 commented Jun 28, 2023

razo7 commented Jun 28, 2023

slintes left a comment • edited Loading

Choose a reason for hiding this comment

slintes Jun 28, 2023

Choose a reason for hiding this comment

slintes Jun 28, 2023

Choose a reason for hiding this comment

slintes Jun 28, 2023

Choose a reason for hiding this comment

razo7 commented Jun 29, 2023 • edited by openshift-ci bot Loading

razo7 commented Jun 29, 2023

slintes commented Jun 29, 2023

razo7 commented Jun 29, 2023

razo7 commented Jun 29, 2023

openshift-ci bot commented Jul 3, 2023

razo7 commented Jun 12, 2023 •

edited

Loading

razo7 commented Jun 25, 2023 •

edited

Loading

slintes left a comment •

edited

Loading

razo7 commented Jun 29, 2023 •

edited by openshift-ci bot

Loading