-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tools and API Versions #56
Merged
openshift-merge-robot
merged 6 commits into
medik8s:main
from
razo7:update-tools-v0.1.0+
Jul 3, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1348b0b
Update tools versions
razo7 5b05d33
Add write/delete permissions for envtest target
razo7 749355c
Update Kubernetes and OpenShift pacakages
razo7 0565d41
Use OCP client-go for fetching machine client
razo7 49a35cc
Run make go-verify
razo7 a745ec7
Apply controller-gen and Operator-sdk changes
razo7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,21 +3,22 @@ | |
# See https://github.com/kubernetes-sigs/kustomize for the last version | ||
KUSTOMIZE_VERSION ?= [email protected] | ||
# https://github.com/kubernetes-sigs/controller-tools/releases for the last version | ||
CONTROLLER_GEN_VERSION ?= v0.8.0 | ||
CONTROLLER_GEN_VERSION ?= v0.12.0 | ||
# See https://pkg.go.dev/sigs.k8s.io/controller-runtime/tools/setup-envtest?tab=versions for the last version | ||
ENVTEST_VERSION ?= v0.0.0-20221022092956-090611b34874 | ||
# Why to use the git commit sha? https://github.com/kubernetes-sigs/controller-runtime/issues/1670 | ||
ENVTEST_VERSION ?= v0.0.0-20230620070423-a784ee78d04b | ||
# See https://github.com/onsi/ginkgo/releases for the last version | ||
GINKGO_VERSION ?= v2.11.0 | ||
# See https://pkg.go.dev/golang.org/x/tools/cmd/goimports?tab=versions for the last version | ||
GOIMPORTS_VERSION ?= v0.6.0 | ||
# See github.com/operator-framework/operator-registry/releases for the last version | ||
OPM_VERSION ?= v1.26.2 | ||
# See github.com/operator-framework/operator-sdk/releases for the last version | ||
OPERATOR_SDK_VERSION ?= v1.26.0 | ||
GOIMPORTS_VERSION ?= v0.10.0 | ||
# See https://github.com/slintes/sort-imports/releases for the last version | ||
SORT_IMPORTS_VERSION = v0.2.1 | ||
# See https://github.com/onsi/ginkgo/releases for the last version | ||
GINKGO_VERSION ?= v2.9.5 | ||
# See https://github.com/operator-framework/operator-registry/releases for the last version | ||
OPM_VERSION ?= v1.28.0 | ||
# See https://github.com/operator-framework/operator-sdk/releases for the last version | ||
OPERATOR_SDK_VERSION ?= v1.30.0 | ||
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary. | ||
ENVTEST_K8S_VERSION = 1.23 | ||
ENVTEST_K8S_VERSION = 1.27 | ||
|
||
# IMAGE_REGISTRY used to indicate the registery/group for the operator, bundle and catalog | ||
IMAGE_REGISTRY ?= quay.io/medik8s | ||
|
@@ -265,19 +266,19 @@ CONTROLLER_GEN_DIR ?= $(LOCALBIN)/controller-gen | |
ENVTEST_DIR ?= $(LOCALBIN)/setup-envtest | ||
GINKGO_DIR ?= $(LOCALBIN)/ginkgo | ||
GOIMPORTS_DIR ?= $(LOCALBIN)/goimports | ||
SORT_IMPORTS_DIR ?= $(LOCALBIN)/sort-imports | ||
OPM_DIR = $(LOCALBIN)/opm | ||
OPERATOR_SDK_DIR ?= $(LOCALBIN)/operator-sdk | ||
SORT_IMPORTS_DIR ?= $(LOCALBIN)/sort-imports | ||
|
||
## Specific Tool Binaries | ||
KUSTOMIZE = $(KUSTOMIZE_DIR)/$(KUSTOMIZE_VERSION)/kustomize | ||
CONTROLLER_GEN = $(CONTROLLER_GEN_DIR)/$(CONTROLLER_GEN_VERSION)/controller-gen | ||
ENVTEST = $(ENVTEST_DIR)/$(ENVTEST_VERSION)/setup-envtest | ||
GINKGO = $(GINKGO_DIR)/$(GINKGO_VERSION)/ginkgo | ||
GOIMPORTS = $(GOIMPORTS_DIR)/$(GOIMPORTS_VERSION)/goimports | ||
SORT_IMPORTS = $(SORT_IMPORTS_DIR)/$(SORT_IMPORTS_VERSION)/sort-imports | ||
OPM = $(OPM_DIR)/$(OPM_VERSION)/opm | ||
OPERATOR_SDK = $(OPERATOR_SDK_DIR)/$(OPERATOR_SDK_VERSION)/operator-sdk | ||
SORT_IMPORTS = $(SORT_IMPORTS_DIR)/$(SORT_IMPORTS_VERSION)/sort-imports | ||
|
||
.PHONY: kustomize | ||
kustomize: ## Download kustomize locally if necessary. | ||
|
@@ -289,6 +290,9 @@ controller-gen: ## Download controller-gen locally if necessary. | |
|
||
.PHONY: envtest ## This library helps write integration tests for your controllers by setting up and starting an instance of etcd and the Kubernetes API server, without kubelet, controller-manager or other components. | ||
envtest: ## Download envtest-setup locally if necessary. | ||
ifneq ($(wildcard $(ENVTEST_DIR)),) | ||
chmod -R +w $(ENVTEST_DIR) | ||
endif | ||
$(call go-install-tool,$(ENVTEST),$(ENVTEST_DIR),sigs.k8s.io/controller-runtime/tools/setup-envtest@${ENVTEST_VERSION}) | ||
|
||
.PHONY: ginkgo | ||
|
@@ -360,7 +364,7 @@ endef | |
|
||
.PHONY: build-tools | ||
build-tools: ## Download & build all the tools locally if necessary. | ||
$(MAKE) kustomize controller-gen envtest ginkgo opm operator-sdk | ||
$(MAKE) kustomize controller-gen envtest goimports sort-imports ginkgo opm operator-sdk | ||
|
||
# Set CATALOG_BASE_IMG to an existing catalog image tag to add $BUNDLE_IMGS to that image. | ||
ifneq ($(origin CATALOG_BASE_IMG), undefined) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting... in /config this status is removed completely from the CRDs, here just the list values change 🤔 🤷