[WIP] MHC created CR isn't deleted by the remediator #347
Conversation
|
Skipping CI for Draft Pull Request. |
mshitrit
changed the title
|
/test ? |
|
@mshitrit: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test 4.16-openshift-e2e |
1. CR is created with regular (non generated) machine name when using a multiple support template 2. Multiple template Annotation placed on the CR contains the correct node/template name Signed-off-by: Michael Shitrit <[email protected]>
This severs two purpuses: - It will be set on NodeName annotation instead of previouslly set machine Name for MHC use case. - Indication that for MHC remediation, in which case the normal (non generated) Machine name is set as the CR name Signed-off-by: Michael Shitrit <[email protected]>
mshitrit
force-pushed
the
wrong-cr-name-machine
branch
from
4d047c2
to
e96b911
Compare
|
/test 4.16-openshift-e2e |
…t machine name when checking NodeName annotation. Signed-off-by: Michael Shitrit <[email protected]>
|
/test 4.16-openshift-e2e |
Signed-off-by: Michael Shitrit <[email protected]>
|
/test 4.16-openshift-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshitrit, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… cr is removed Signed-off-by: Michael Shitrit <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
/test 4.16-openshift-e2e |
|
@mshitrit: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Why we need this PR
When a CR is created by MHC it's not deleted by the remediator (SNR) in case the remediator supports multiple templates.
The reason is that when MHC creates the CR it creates a generated name for the CR which does not match the machine name.
When the same apply for node base remediation the additional (node name and template name) info is stored in annotations on the CR, but for machine based remediation the remediator doesn't access those annotations.
Changes made
Which issue(s) this PR fixes
ECOPROJECT-2077
Test plan
Added a regression test