Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] MHC created CR isn't deleted by the remediator #347

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] MHC created CR isn't deleted by the remediator #347

wants to merge 5 commits into from

Commits on Sep 10, 2024

  1. unit tests that checks: 

    1. CR is created with regular (non generated) machine name when using a multiple support template
2. Multiple template Annotation placed on the CR contains the correct node/template name

Signed-off-by: Michael Shitrit <[email protected]>
    @mshitrit
    mshitrit committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    297d0ec View commit details
    Browse the repository at this point in the history

  2. Generating a CR will receieve the nodeName. 

    This severs two purpuses:
- It will be set on NodeName annotation instead of previouslly set machine Name for MHC use case.
- Indication that for MHC remediation, in which case the normal (non generated) Machine name is set as the CR name

Signed-off-by: Michael Shitrit <[email protected]>
    @mshitrit
    mshitrit committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e96b911 View commit details
    Browse the repository at this point in the history

  3. Fix e2e test to verify existense of remediation CR by nodeName and no… 

    …t machine name when checking NodeName annotation.

Signed-off-by: Michael Shitrit <[email protected]>
    @mshitrit
    mshitrit committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    4dfaa31 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Some minor changes (comments, etc) to improve readability 

    Signed-off-by: Michael Shitrit <[email protected]>
    @mshitrit
    mshitrit committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b45a5c5 View commit details
    Browse the repository at this point in the history

  2. increase grace time in e2e test waiting for lease to be deleted after… 

    … cr is removed

Signed-off-by: Michael Shitrit <[email protected]>
    @mshitrit
    mshitrit committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e51cac5 View commit details
    Browse the repository at this point in the history