Skip to content

Commit

Permalink
Clarify usage of min/max throughput and instances (GoogleCloudPlatfor…
Browse files Browse the repository at this point in the history
…m#10130)

* Clarify usage of min/max throughput and instances

* fix lint

* fix snake casing
  • Loading branch information
jashansudan authored Mar 21, 2024
1 parent d62cd8a commit 2089d74
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions mmv1/products/vpcaccess/Connector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -106,27 +106,34 @@ properties:
- !ruby/object:Api::Type::Integer
name: minThroughput
description: |
Minimum throughput of the connector in Mbps. Default and min is 200.
Minimum throughput of the connector in Mbps. Default and min is 200. Refers to the expected throughput when using an e2-micro machine type.
Value must be a multiple of 100 from 200 through 900. Must be lower than the value specified by max_throughput. If both min_throughput and
min_instances are provided, min_instances takes precedence over min_throughput. The use of min_throughput is discouraged in favor of min_instances.
default_value: 200
validation: !ruby/object:Provider::Terraform::Validation
function: 'validation.IntBetween(200, 1000)'
- !ruby/object:Api::Type::Integer
name: minInstances
description: |
Minimum value of instances in autoscaling group underlying the connector.
Minimum value of instances in autoscaling group underlying the connector. Value must be between 2 and 9, inclusive. Must be
lower than the value specified by max_instances.
default_from_api: true
- !ruby/object:Api::Type::Integer
name: maxInstances
description: |
Maximum value of instances in autoscaling group underlying the connector.
Maximum value of instances in autoscaling group underlying the connector. Value must be between 3 and 10, inclusive. Must be
higher than the value specified by min_instances.
default_from_api: true
- !ruby/object:Api::Type::Integer
name: maxThroughput
# The API documentation says this will default to 200, but when I tried that I got an error that the minimum
# throughput must be lower than the maximum. The console defaults to 1000, so I changed it to that.
# API returns 300 if it is not sent
description: |
Maximum throughput of the connector in Mbps, must be greater than `min_throughput`. Default is 300.
Maximum throughput of the connector in Mbps, must be greater than `min_throughput`. Default is 300. Refers to the expected throughput
when using an e2-micro machine type. Value must be a multiple of 100 from 300 through 1000. Must be higher than the value specified by
min_throughput. If both max_throughput and max_instances are provided, max_instances takes precedence over max_throughput. The use of
max_throughput is discouraged in favor of max_instances.
default_value: 300
validation: !ruby/object:Provider::Terraform::Validation
function: 'validation.IntBetween(200, 1000)'
Expand Down

0 comments on commit 2089d74

Please sign in to comment.