-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix superset docs and pin conflicting dependency #1169
Conversation
✅ Deploy Preview for meltano-hub ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@pnadolny13 The |
@cwegener thanks for that! I went looking and found that the release should be out next week and you linked to apache/superset#22744 that fixes the problem. I'd vote to merge this ASAP, then open an issue to bump to 2.0.2 + remove the cryptography pin after the release next week. UPDATE: issue created #1172 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not a fan of having this as the Meltano variant, but it's not critical we solve for that problem right now. Switching to the EDK as default makes sense to me.
@tayloramurphy yeah thats fair, cross linking back to our previous discussion on this #1135 (comment). I'll open a discussion so it doesn't get lost. #1171 |
Related to meltano/superset-ext#8
cryptography
also see MDS in a box where the same thing was done. I updated for both of these variants