Skip to content

Commit

Permalink
fix: TapDiscoveryTest remove catalog if one is passed (#1364)
Browse files Browse the repository at this point in the history
  • Loading branch information
Ken Payne authored Feb 1, 2023
1 parent c8742f1 commit ed08850
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions singer_sdk/testing/tap_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ def test(self) -> None:
tap1 = self.tap
tap1.run_discovery()
catalog = tap1.catalog_dict
# Reset and re-initialize with an input catalog
# Reset and re-initialize with discovered catalog
kwargs = {k: v for k, v in self.runner.default_kwargs.items() if k != "catalog"}
tap2: Tap = cast(Type[Tap], self.runner.singer_class)(
config=self.runner.config, catalog=catalog, **self.runner.default_kwargs
config=self.runner.config, catalog=catalog, **kwargs
)
assert tap2

Expand Down

0 comments on commit ed08850

Please sign in to comment.