fix: TapDiscoveryTest remove catalog if one is passed #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1364 +/- ##
=======================================
Coverage 85.19% 85.19%
=======================================
Files 54 54
Lines 4693 4694 +1
Branches 797 798 +1
=======================================
+ Hits 3998 3999 +1
Misses 504 504
Partials 191 191
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kgpayne
requested review from
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
|
@edgarrmondragon if you have a chance to look at this small change today I would hugely appreciate it 🙏 It would allow me to use automated tests, and the framework, for testing the changes in tap-snowflake#13 by unblocking tap-snowflake#14 🙂 |
edgarrmondragon
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://meltano-sdk--1364.org.readthedocs.build/en/1364/