Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'master' with 'main' as default branch name #1

Closed
MeltyBot opened this issue Nov 26, 2020 · 1 comment
Closed

Replace 'master' with 'main' as default branch name #1

MeltyBot opened this issue Nov 26, 2020 · 1 comment
Assignees
@aaronsteers
Labels
migrated from gitlab

Comments

@MeltyBot
Copy link
Contributor

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/1

Originally created by @aaronsteers on 2020-11-26 23:29:16

As a general practice, I have found it best practice to avoid 'master' as the primary branch name, and instead use 'main'. This is easier done earlier in the project lifecycle before there are other dependencies.

Process I've used successfully in the past:

  1. Create and push a new branch called 'main' which is at the same position as 'master.
  2. Update default branch settings and branch protection mechanisms to point to 'main'.
  3. Delete 'master' branch.

Happy to discuss additional thoughts and/or further discussion on this.
@MeltyBot
Copy link
Contributor Author

View 2 previous comments from the original issue on GitLab

edgarrmondragon pushed a commit that referenced this issue Jan 30, 2024
@mattwill09
Mattwill09 patch 1 (#1)
6f39c03 
* Update sql.py

* Update test_target_sqlite.py
@edgarrmondragon edgarrmondragon mentioned this issue Jan 30, 2024
Merged
edgarrmondragon added a commit that referenced this issue Jan 30, 2024
@edgarrmondragon @mattwill09
fix(targets): Quote column names in INSERT statement (#2200)
bfc1bc1 
* Update sql.py

* Mattwill09 patch 1 (#1)

* Update sql.py

* Update test_target_sqlite.py

* Update singer_sdk/sinks/sql.py

* Use IdentifierPreparer

---------

Co-authored-by: Matthew Will <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronsteers aaronsteers

Labels
migrated from gitlab
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronsteers @MeltyBot