Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(targets): Quote column names in INSERT statement #2200

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 30, 2024


📚 Documentation preview 📚: https://meltano-sdk--2200.org.readthedocs.build/en/2200/

Copy link

codspeed-hq bot commented Jan 30, 2024

CodSpeed Performance Report

Merging #2200 will not alter performance

Comparing edgarrmondragon/fix/insert-quote-column-names (2334a17) with main (af3b678)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af3b678) 88.43% compared to head (2334a17) 88.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2200      +/-   ##
==========================================
+ Coverage   88.43%   88.46%   +0.02%     
==========================================
  Files          54       54              
  Lines        4714     4716       +2     
  Branches      961      962       +1     
==========================================
+ Hits         4169     4172       +3     
+ Misses        384      383       -1     
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 30, 2024 21:49
@edgarrmondragon edgarrmondragon merged commit bfc1bc1 into main Jan 30, 2024
33 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/insert-quote-column-names branch January 30, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants