Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NoCredentialProviders error when accessing public bucket on Minio #133

Merged
merged 3 commits into from
Aug 3, 2020
Merged

Fix NoCredentialProviders error when accessing public bucket on Minio #133

merged 3 commits into from
Aug 3, 2020

Conversation

Codebreaker101
Copy link
Contributor

@Codebreaker101 Codebreaker101 commented Jul 7, 2020 •
edited
Loading

Fixes #132

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).
  • Ensure documentation is up-to-date. The same file will be updated in plugin index when your PR is accepted, so it will be available for end-users at http://plugins.drone.io.

@Codebreaker101
Copy link
Contributor Author

@kakkoyun any updates on this?

@kakkoyun kakkoyun changed the title fix #132 Fix NoCredentialProviders error when accessing public bucket on Minio Jul 30, 2020
kakkoyun
kakkoyun reviewed Jul 30, 2020
View reviewed changes
Copy link
Contributor

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Codebreaker101 Sorry for the late response and thanks for the contribution.
This looks solid. I just wonder have you tested this against real AWS S3 API not just Minio?

@kakkoyun
Copy link
Contributor

@Codebreaker101 And rebasing your branch onto latest master should solve the CI problems.

@Codebreaker101
Copy link
Contributor Author

I have not tested it on AWS S3, but the object was taken straight from the documentation so it should work with no issues.

kakkoyun
kakkoyun approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's see how it goes. LGTM.

@kakkoyun kakkoyun merged commit 8a3c468 into meltwater:master Aug 3, 2020
@Codebreaker101 Codebreaker101 deleted the fix_anonymous_credentials branch August 3, 2020 08:43
@jimsheldon jimsheldon mentioned this pull request Sep 30, 2021
Closed
@jimsheldon
Copy link

Looks like this introduced a regression that is being tracked in #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

@limayekaiwalya limayekaiwalya Awaiting requested review from limayekaiwalya

@seandtaber seandtaber Awaiting requested review from seandtaber seandtaber is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NoCredentialProviders error when accessing public bucket on Minio
3 participants
@Codebreaker101 @kakkoyun @jimsheldon