Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoCredentialProviders error when accessing public bucket on Minio #133

Merged
merged 3 commits into from
Aug 3, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

- Fixed Anonymous Credentials Error on public buckets
- Fixes [#132](https://github.com/meltwater/drone-cache/issues/132)

### Added

- [#102](https://github.com/meltwater/drone-cache/pull/102) Implement option to disable cache rebuild if it already exists in storage.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ USAGE:
drone-cache [global options] command [command options] [arguments...]

VERSION:
v1.1.0-rc0
v1.1.0

COMMANDS:
help, h Shows a list of commands or help for one command
Expand Down
1 change: 1 addition & 0 deletions storage/backend/s3/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ func New(l log.Logger, c Config, debug bool) (*Backend, error) {
Endpoint: &c.Endpoint,
DisableSSL: aws.Bool(!strings.HasPrefix(c.Endpoint, "https://")),
S3ForcePathStyle: aws.Bool(c.PathStyle),
Credentials: credentials.AnonymousCredentials,
}

if c.Key != "" && c.Secret != "" {
Expand Down