Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service delete should expect its instances stopped first #1057

Closed
ilgooz opened this issue Jun 16, 2019 · 0 comments
Closed

service delete should expect its instances stopped first #1057

ilgooz opened this issue Jun 16, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@ilgooz
Copy link
Contributor

ilgooz commented Jun 16, 2019

otherwise should give an error.

#1037 (comment)
@ilgooz ilgooz added the bug Something isn't working label Jun 16, 2019
ilgooz added a commit that referenced this issue Jun 18, 2019
@ilgooz
sdk/service:delete: [fix] require service's instances been stopped be…
e7dc613 
…fore delete

and add GetAllByService() methods to instance sdk and instance database.

fixes #1057.
@ilgooz ilgooz mentioned this issue Jun 18, 2019
Closed
ilgooz added a commit that referenced this issue Jun 19, 2019
@ilgooz
add servicesdk.Delete() feature and its gRPC API
4f8733c 
and require service's instances been stopped beforedelete in the gRPC API.
and add GetAllByService() methods to instance sdk and instance database in order to do that.

fixes #1057.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@ilgooz