Delete instance api #1037
Merged
Delete instance api #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
force-pushed
the
feature/instance-delete-server
branch
from
59f5069
to
e937c55
Compare
antho1404
force-pushed
the
feature/instance-delete-server
branch
from
77f3e5c
to
eaa1873
Compare
|
service:delete deletes the service even if an instance is running which is the opposite behavior in the proposal |
krhubert
reviewed
Jun 9, 2019
| } | ||
|
|
||
| message DeleteInstanceResponse { | ||
| string hash = 1; // Instance hash |
There was a problem hiding this comment.
why return instance hash in response if it was sent in the request
There was a problem hiding this comment.
I don't mind much about that, I can remove but the idea is that when we delete a resource we have the id of the resource delete in order to be able to have a full asynchrony application that can on one side send the request and on the other side just receive the result and know how to update a local store or anything.
But again I'm happy to delete it if needed
krhubert
reviewed
Jun 9, 2019
This was referenced Jun 10, 2019
Merged
Merged
…esg-foundation/core into feature/instance-delete-server
NicolasMahe
previously approved these changes
Jun 16, 2019
ilgooz
force-pushed
the
feature/instance-delete-server
branch
from
f65a512
to
3b77b73
Compare
ilgooz
approved these changes
Jun 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency: #1036