Update service db to use store #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base system that accept a store.
NicolasMahe
added
waiting dependent pr
release:change
antho1404
approved these changes
Aug 22, 2019
antho1404
approved these changes
Aug 22, 2019
antho1404
approved these changes
Aug 22, 2019
|
This pull request has been mentioned on MESG Community. There might be relevant details there: https://forum.mesg.com/t/network-implementation-with-cosmossdk/304/15 |
krhubert
reviewed
Aug 22, 2019
| @@ -82,7 +84,10 @@ func TestServiceDBDelete(t *testing.T) { | |||
| require.IsType(t, &ErrNotFound{}, err) | |||
| } | |||
|
|
|||
| // TOFIX: the database is not thread safe anymore... | |||
There was a problem hiding this comment.
the database is still thread safe, but the question is why the transaction has gone
There was a problem hiding this comment.
kvstore does not implement transaction as it should modify and read the store one transaction at a time. so they don't need concurrent access..
krhubert
reviewed
Aug 22, 2019
# Conflicts: # database/service_db.go
krhubert
approved these changes
Aug 23, 2019
NicolasMahe
removed
the
release:change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependant on #1243