Add data validation to all resources

[krhubert]

close #1505

[NicolasMahe]

Could you also move the function validateServiceStruct from service validator package and make it generic:

engine/service/validator/validator.go

Lines 28 to 45 in 6df2444

	func validateServiceStruct(s *service.Service) error {
	var errs xerrors.Errors
	// validate service struct based on tag
	if err := validate.Struct(s); err != nil {
	for _, e := range err.(validator.ValidationErrors) {
	// Remove the name of the struct and the field from namespace
	trimmedNamespace := strings.TrimPrefix(e.Namespace(), namespacePrefix)
	trimmedNamespace = strings.TrimSuffix(trimmedNamespace, e.Field())
	// Only use it when in-cascade field
	namespace := ""
	if e.Field() != trimmedNamespace {
	namespace = trimmedNamespace
	}
	errs = append(errs, fmt.Errorf("%s%s", namespace, e.Translate(translator)))
	}
	}
	return errs.ErrorOrNil()
	}

to something like:

func Validate(s interface{}) error {
	 validate, translator := New()
	var errs xerrors.Errors
	// validate service struct based on tag
	if err := validate.Struct(s); err != nil {
		for _, e := range err.(validator.ValidationErrors) {
			// Remove the name of the struct and the field from namespace
			trimmedNamespace := strings.TrimPrefix(e.Namespace(), namespacePrefix)
			trimmedNamespace = strings.TrimSuffix(trimmedNamespace, e.Field())
			// Only use it when in-cascade field
			namespace := ""
			if e.Field() != trimmedNamespace {
				namespace = trimmedNamespace
			}
			errs = append(errs, fmt.Errorf("%s%s", namespace, e.Translate(translator)))
		}
	}
	return errs.ErrorOrNil()
}

I guess having a simple helper that improve the error and manage the translation will be better ;)

[NicolasMahe]

Also, the remaining functions in service/validator package should be move to service package.

[krhubert]

For now I left it in the service, because I'm not sure if we want such generic validation everywhere. It was designed for service only.

But I've moved the creation of Validate

[krhubert]

I've left validation for cosmos app (backend), because it could be easily done when PR about execution #1463 will be merged.

Then validation will be done in the handler for every message. I haven't found middleware (or some similar concept) for cosmos handlers.

[NicolasMahe]

Suggested change

	(gogoproto.moretags) = 'validate:"hash"',
	(gogoproto.moretags) = 'validate:"required,hash"',

[NicolasMahe]

Suggested change

	(gogoproto.moretags) = 'validate:"printascii"'
	(gogoproto.moretags) = 'validate:"required,printascii"'

[NicolasMahe]

I'm not sure it's the best place here.
I would like the SDK to also check its inputs and a lot of grpc request message are directly forward to the sdk.
maybe check at both place?

[krhubert]

Why SDK should check that. For now we use only grpc as entry for sdk. SDK transforms over time and for now, you just can't use it without running engine. So it should stay here for now. And when sdk transforms to the point where you can use it without engine, then we might add the validation here.

[NicolasMahe]

I just think that the verification should be done in last entry point of the app.
We also plan to move to SDK the definition of the message, so it will make even more sense to already put the verification in SDK.

[krhubert]

what is the last entry point? For now, it is the cosmos app and there messages are validated. SDK is a kind of middleware between our grpc api and cosmos api.

We also plan to move to SDK the definition of the message,

Then we will move the validation as well, but for now let's keep it as it is.

[NicolasMahe]

Then validation will be done in the handler for every message. I haven't found middleware (or some similar concept) for cosmos handlers.

each cosmos message has to implement func (msg msgCreateRunner) ValidateBasic() cosmostypes.Error. the validation should be done there.

[NicolasMahe]

Also add required to instanceHash and data

[NicolasMahe]

in CreateEventRequest

[NicolasMahe]

please make the last modif and merge