Update process structure: rename process's key to name and move node.*.key into node #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
reviewed
Nov 29, 2019
- change stepID to nodeKey - remove database process tests
krhubert
force-pushed
the
refactor/process
branch
from
d9f47ae
to
50cf002
Compare
antho1404
reviewed
Nov 30, 2019
NicolasMahe
reviewed
Dec 2, 2019
| oneof type { | ||
| // Result is a trigger that listens for a specific result. | ||
| Result result = 1 [ | ||
| (gogoproto.moretags) = 'hash:"name:1"' | ||
| Result result = 2 [ |
There was a problem hiding this comment.
i think you don't need to start from 0 in a oneof
|
Let's wait for issue #1427 to be closed before merging this PR |
antho1404
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Ready to merge for me when the tests e2e is ready.
You can use this PR for mesg-foundation/js-sdk#148 if you want to test
NicolasMahe
approved these changes
Dec 4, 2019
3 tasks
NicolasMahe
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1534
close #1535
Move node.*.key into node and rename process.key to name