Implement nested data map in process and change process map structure #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
force-pushed
the
feature/nested-data
branch
2 times, most recently
from
7bea517
to
364aa0c
Compare
krhubert
force-pushed
the
feature/nested-data
branch
from
364aa0c
to
8c6b914
Compare
|
TODO:
|
NicolasMahe
reviewed
Dec 5, 2019
NicolasMahe
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
except this comment #1540 (comment) i'm good with this PR :)
antho1404
requested changes
Dec 11, 2019
…unction to Process_Node_Map to convert map to key value. Add amino unsafe flag to map's double_const parameter.
…rt map to key value.
antho1404
approved these changes
Dec 11, 2019
NicolasMahe
changed the title
NicolasMahe
changed the title
NicolasMahe
changed the title
NicolasMahe
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dep #1536
close #1304
Changes in process.proto:
repeated Output outputstomap<string, Output> outputsThose changes are required to implement both object and array. Doing only NestedObject as @NicolasMahe suggested is not engouth to implement array type. I don't see any other way to do that.
Missing: