Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account number used for signing tx #1598

Merged
merged 6 commits into from
Jan 14, 2020
Merged

Fix account number used for signing tx #1598

merged 6 commits into from
Jan 14, 2020

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Jan 13, 2020

Dependant on #1553
Closes #1583

@NicolasMahe NicolasMahe self-assigned this Jan 13, 2020
@NicolasMahe NicolasMahe added waiting dependent pr release:fix Pull requests that fix something labels Jan 13, 2020
@NicolasMahe NicolasMahe added this to the next milestone Jan 13, 2020
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AccNumber in cosmos/keybase should be removed to make sure we don't want to use it (also AccIndex.
In the main#loadOrGenConfigAccount we should read the values from the config/flag/constant (I vote for config).

@antho1404
Copy link
Member

Fixed in #1599

Move AccNumber and AccIndex to the config
@antho1404 antho1404 merged commit 9b85b26 into dev Jan 14, 2020
@antho1404 antho1404 deleted the fix/account-number branch January 14, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix Pull requests that fix something waiting dependent pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

account number in keybase is not the same as account number in tx builder
2 participants