Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fees and estimation of tx's gas #1553

Merged
merged 11 commits into from
Jan 13, 2020
Merged

Add fees and estimation of tx's gas #1553

merged 11 commits into from
Jan 13, 2020

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Dec 9, 2019 •
edited
Loading

closes #1564

@NicolasMahe NicolasMahe self-assigned this Dec 9, 2019
NicolasMahe
NicolasMahe commented Dec 10, 2019
View reviewed changes
cosmos/appfactory.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe commented Dec 10, 2019
View reviewed changes
cosmos/client.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe commented Dec 10, 2019
View reviewed changes
cosmos/client.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe commented Dec 10, 2019
View reviewed changes
cosmos/genesis.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe commented Dec 10, 2019
View reviewed changes
cosmos/txbuilder.go Outdated Show resolved Hide resolved
@NicolasMahe NicolasMahe marked this pull request as ready for review January 13, 2020 05:46
@NicolasMahe NicolasMahe added this to the next milestone Jan 13, 2020
@NicolasMahe NicolasMahe changed the title Add fees and calculation of tx's gas Add fees and estimation of tx's gas Jan 13, 2020
@NicolasMahe NicolasMahe mentioned this pull request Jan 13, 2020
Merged
antho1404
antho1404 approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-01-13 at 18 29 41

Screen Shot 2020-01-13 at 18 29 51

Screen Shot 2020-01-13 at 18 29 58

Screen Shot 2020-01-13 at 18 30 21

99% of gas used, pretty good 🎉

@antho1404 antho1404 merged commit 6eb0c1c into dev Jan 13, 2020
@antho1404 antho1404 deleted the feature/fees branch January 13, 2020 11:38
@NicolasMahe NicolasMahe added the release:add Pull requests that add something label Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krhubert krhubert krhubert approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees

@krhubert krhubert

@NicolasMahe NicolasMahe

Labels
release:add Pull requests that add something
Projects
None yet
Milestone
v0.18.1
Development

Successfully merging this pull request may close these issues.

Enforce tx fees and estimate the tx gas properly
3 participants
@NicolasMahe @antho1404 @krhubert