Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change gogoproto's customtype to casttype #1756

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Change gogoproto's customtype to casttype #1756

merged 3 commits into from
Mar 27, 2020

Conversation

NicolasMahe
Copy link
Member

  • change gogoproto's customtype to casttype
  • remove now-useless proto marshal from hash.Hash

Related to #1741

@NicolasMahe NicolasMahe added the release:change Pull requests that change something existant label Mar 27, 2020
@NicolasMahe NicolasMahe added this to the next milestone Mar 27, 2020
@NicolasMahe NicolasMahe self-assigned this Mar 27, 2020
@NicolasMahe NicolasMahe mentioned this pull request Mar 27, 2020
Closed
8 tasks
antho1404
antho1404 approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@antho1404 antho1404 merged commit 2963f35 into dev Mar 27, 2020
@antho1404 antho1404 deleted the feature/gogoproto-casttype branch March 27, 2020 11:11
@NicolasMahe NicolasMahe mentioned this pull request Apr 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

Assignees

@NicolasMahe NicolasMahe

Labels
release:change Pull requests that change something existant
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasMahe @antho1404