Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated gRPC API #1774

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Remove deprecated gRPC API #1774

merged 4 commits into from
Apr 8, 2020

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Apr 7, 2020

Dependent on #1773
Closes #1764

This PR removes the deprecated gRPC API.
But in order to do so, I had to replace the cosmos module_client by the cosmos RPC client across the codebase: 9b1fa55

Diff:
https://github.com/mesg-foundation/engine/pull/1774/files/fdecdda4d5beb336980e2145ba050872236a0682..46a3994dd48786ba405e88b5bceac5b42824ef2f

@NicolasMahe NicolasMahe added waiting dependent pr release:remove Pull requests that remove something labels Apr 7, 2020
@NicolasMahe NicolasMahe added this to the next milestone Apr 7, 2020
@NicolasMahe NicolasMahe self-assigned this Apr 7, 2020
This was referenced Apr 7, 2020
@NicolasMahe NicolasMahe added breaking change and removed release:remove Pull requests that remove something labels Apr 7, 2020
@antho1404 antho1404 merged commit 08bfc2d into dev Apr 8, 2020
@antho1404 antho1404 deleted the remove/deprecated-grpc-api branch April 8, 2020 11:20
@NicolasMahe NicolasMahe mentioned this pull request Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve gRPC API
2 participants