Simplify container #1775
Merged
Simplify container #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
added
waiting dependent pr
release:change
…ng container package a lot. Update e2e with it.
NicolasMahe
force-pushed
the
feature/simplify-container
branch
from
aa41418
to
d5f0eb8
Compare
NicolasMahe
commented
Apr 7, 2020
NicolasMahe
commented
Apr 7, 2020
NicolasMahe
commented
Apr 7, 2020
antho1404
approved these changes
Apr 8, 2020
|
We should now be able to safely remove the bind of the docker socket when we start the engine :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #1774
This PR merges the
runner/builderpackage intocontainerpackage and simplifying it a lot (no more intermediary struct between the service and docker).Diff of only this PR against the previous:
https://github.com/mesg-foundation/engine/pull/1775/files/46a3994dd48786ba405e88b5bceac5b42824ef2f..d5f0eb8be5a00ed953e0572bf3f35e7e880a214d