-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pre-configured dev docker image #1806
Conversation
541bd23
to
9760e71
Compare
@@ -70,7 +70,7 @@ jobs: | |||
- run: docker swarm init | |||
- <<: *restore_go_cache | |||
- <<: *restore_go_path | |||
- run: make e2e | |||
- run: make e2e version=`echo $CIRCLE_SHA1 | cut -c1-7` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is reverted in the next PR (i set a default value to version)
ARG from | ||
FROM $from | ||
|
||
COPY ./dev-chain/cli /root/.mesg-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just generate all the commands in the docker file instead of copy the files. This way we don't have to store and maintain the files and we can still have a deterministic chain with mnemonic as args of the docker.
I'm afraid that we will have a lot of issues if we do some migration of the genesis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's could be possible but I think there will be some issue with the way the cosmos commands takes password: there is not password flag and the passwords are read directly from stdin.
I would like to do this (if possible) in another PR.
There will not be any migration of genesis as this dev version is intended to be used on temp volume that are discarded at every start/stop of the associated docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration I'm talking about is if we add a new parameter and the structure of the genesis changes for some reasons. It would be better to re-generate it all the time or at least have tests to ensure that breaking changes on the genesis will be changed on the dev directory. But otherwise yes a script if possible would be nice in another PR but not a priority
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this current version, if the genesis is not valid, then the e2e tests will breaks.
dependent on #1801 and #1808
related to #1815
dev-chain
.