Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CLI based Engine #1810

Merged
merged 3 commits into from
May 8, 2020
Merged

Switch to CLI based Engine #1810

merged 3 commits into from
May 8, 2020

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented May 6, 2020

closes #1815

Dependent on #1806

  • update dockerfile to switch to only CLI based engine
    • tag mesg/engine:vX.X.X is for production version containing both mesg-cli and mesg-daemon. By default it runs mesg-daemon start.
    • tag mesg/engine:unstable is for testing of the version of branch dev (previously tag mesg/engine:dev)
    • tag mesg/engine:XXX-devis for local easy-to-use. this image contains a hardcoded genesis and will start the tendermint node, the orchestrator, and the LCD in the same container. It is only intended for local development.
  • remove all unused go files:
    • core
    • config (cosmos related stuff move to cosmos/config)
    • cosmos/genesis
    • cosmos/node
    • logger (only used to create a special logger for tendermint node)
    • version

@NicolasMahe NicolasMahe requested a review from antho1404 May 6, 2020 06:45
@NicolasMahe NicolasMahe self-assigned this May 6, 2020
@NicolasMahe NicolasMahe changed the title Feature/remove core Switch to CLI based engine May 6, 2020
@NicolasMahe NicolasMahe changed the title Switch to CLI based engine Switch to CLI based Engine May 6, 2020
@NicolasMahe NicolasMahe added this to the next milestone May 6, 2020
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice cleanup, waiting for dependent PR but everything seems valid

@NicolasMahe NicolasMahe merged commit c0f2bfd into dev May 8, 2020
@NicolasMahe NicolasMahe deleted the feature/remove-core branch May 8, 2020 05:03
@NicolasMahe NicolasMahe mentioned this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Engine architecture
2 participants