Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace improve checks #874

Merged
merged 24 commits into from
Apr 19, 2019
Merged

Marketplace improve checks #874

merged 24 commits into from
Apr 19, 2019

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Apr 12, 2019 •
edited
Loading

Related to #838

Move a lots of checks from CLI to the service itself.

Todo that can be done in other PR:

  • [preparePublishServiceVersion.ts] add check on SID is domain name (see go implementation)
  • [preparePublishServiceVersion.ts] check if version already exist on marketplace
    Edit: done in Marketplace: add more checks #899

@NicolasMahe
Add function isServiceExist
77a705a
@NicolasMahe
Introduce requireServiceExist function
c56df57
@NicolasMahe
Number passed to toUnit function cannot be negative
8000ecb
@NicolasMahe
Add data check in createServiceOffer
ded4dc9
@NicolasMahe
Add data check in publishServiceVersion
f816b41
@NicolasMahe
Add data check in purchase
eb34d31
@NicolasMahe
Add comments
3d3cb03
@NicolasMahe
Remove unnecessary import
434a093
@NicolasMahe
Remove unnecessary check in marketplace commands
1f0151a
@NicolasMahe
fix lint
3f4431e
@NicolasMahe
Merge commit '90cf8700d6dcabb097c712721892d09b571a5bc7' into ss/marke…
402c9b9 
…tplace-improve-checks

# Conflicts:
#	systemservices/marketplace/src/contracts/offer.ts
#	systemservices/marketplace/src/contracts/purchase.ts
#	systemservices/marketplace/src/contracts/service.ts
#	systemservices/marketplace/src/contracts/version.ts
#	systemservices/marketplace/src/tasks/isAuthorized.ts
#	systemservices/marketplace/src/tasks/prepareCreateServiceOffer.ts
#	systemservices/marketplace/src/tasks/preparePublishServiceVersion.ts
@NicolasMahe
lowercase error message
dc91f4b
@NicolasMahe
add todo
83467a5
@NicolasMahe
fix length
6fd5b36
@NicolasMahe
Fix checks and improve error messages
347a5a0
@NicolasMahe NicolasMahe marked this pull request as ready for review April 16, 2019 12:52
@NicolasMahe NicolasMahe mentioned this pull request Apr 16, 2019
Closed
antho1404
antho1404 reviewed Apr 17, 2019
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of if(cond) throw new Error(message), there is nothing wrong with that but we could use an assert lib for that assert(cond, message). This would be more readable in my opinion.

commands/marketplace_purchase.go Show resolved Hide resolved
systemservices/marketplace/src/tasks/prepareCreateServiceOffer.ts Outdated Show resolved Hide resolved
systemservices/marketplace/src/tasks/preparePublishServiceVersion.ts Outdated Show resolved Hide resolved
@NicolasMahe NicolasMahe force-pushed the ss/marketplace-improve-checks branch from c171b5d to d7e9b98 Compare April 18, 2019 10:38
ilgooz
ilgooz reviewed Apr 18, 2019
View reviewed changes
Copy link
Contributor

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual tests are ok

@NicolasMahe NicolasMahe mentioned this pull request Apr 19, 2019
Merged
2 tasks
@NicolasMahe NicolasMahe requested a review from ilgooz April 19, 2019 08:50
@NicolasMahe NicolasMahe merged commit 15cf94a into dev Apr 19, 2019
@NicolasMahe NicolasMahe deleted the ss/marketplace-improve-checks branch April 19, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@ilgooz ilgooz ilgooz approved these changes

@krhubert krhubert Awaiting requested review from krhubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasMahe @antho1404 @ilgooz