Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace: add more checks #899

Merged
merged 9 commits into from
Apr 20, 2019
Merged

Marketplace: add more checks #899

merged 9 commits into from
Apr 20, 2019

Conversation

NicolasMahe
Copy link
Member

Dependant on #874

  • [preparePublishServiceVersion.ts] add check on SID is domain name (see go implementation)
  • [preparePublishServiceVersion.ts] check if version already exist on marketplace

@NicolasMahe NicolasMahe mentioned this pull request Apr 19, 2019
Merged
2 tasks
@NicolasMahe NicolasMahe changed the title Ss/marketplace improve checks more Marketplace: add more checks Apr 19, 2019
ilgooz
ilgooz approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is ok 👍

@antho1404
Copy link
Member

probably not related but i can't deploy a service, i'm stuck on the step ⣽ Publishing service on the marketplace...

and the marketplace service logs contains

service | catch promise Error: Invalid JSON RPC response: ""
service |     at Object.InvalidResponse (/app/node_modules/web3-core-helpers/src/errors.js:42:16)
service |     at XMLHttpRequest.request.onreadystatechange (/app/node_modules/web3-providers-http/src/ind

@NicolasMahe
Copy link
Member Author

NicolasMahe commented Apr 19, 2019 •
edited
Loading

probably not related but i can't deploy a service, i'm stuck on the step ⣽ Publishing service on the marketplace...

and the marketplace service logs contains

service | catch promise Error: Invalid JSON RPC response: ""
service |     at Object.InvalidResponse (/app/node_modules/web3-core-helpers/src/errors.js:42:16)
service |     at XMLHttpRequest.request.onreadystatechange (/app/node_modules/web3-providers-http/src/ind

Looks like an error between your computer and infura... Try maybe another infura api key

@antho1404 antho1404 merged commit 2c3be36 into dev Apr 20, 2019
@antho1404 antho1404 deleted the ss/marketplace-improve-checks-more branch April 20, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@ilgooz ilgooz ilgooz approved these changes

@krhubert krhubert Awaiting requested review from krhubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasMahe @antho1404 @ilgooz