-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go through coreutils.compiler_options.{build.host.target} #4626
Go through coreutils.compiler_options.{build.host.target} #4626
Conversation
870ec18
to
e5c3f55
Compare
Flake8 detected 10 issues on e5c3f55 posted by Sider |
b8865b4
to
9ac92a2
Compare
9ac92a2
to
3edcdf0
Compare
8cb6082
to
3b3bf0c
Compare
1e05fe4
to
58f7902
Compare
This PR works and is itself done, but needs to be rebased once #4733 is merged. |
b86b7b8
to
053cd53
Compare
@dcbaker have time to review this too? |
All compilers should define this attribute. Probably should change base class to require this.
435a27c
to
cac9c95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got a few small things I'd like to see fixed, but otherwise this looks good.
cac9c95
to
871efd4
Compare
Instead use coredata.compiler_options.<machine>. This brings the cross and native code paths closer together, since both now use that. Command line options are interpreted just as before, for backwards compatibility. This does introduce some funny conditionals. In the future, I'd like to change the interpretation of command line options so - The logic is cross-agnostic, i.e. there are no conditions affected by `is_cross_build()`. - Compiler args for both the build and host machines can always be controlled by the command line. - Compiler args for both machines can always be controlled separately.
871efd4
to
19f81d3
Compare
@dcbaker OK all your changes are fixed, along with the Sider issues I accidentally reintroduced in the process. |
Never access
environment.properties
downstream. Instead use coredata.compiler_options.. This brings the cross and native code paths closer together, since both now use that.#4772 builds on this to further remove a bunch of conditional code now that the underlying mechanism is the same. It has some CI failures though hence why I didn't do that low-hanging fruit as part of this PR.
Command line options are interpreted just as before, for backwards compatibility. Doing so does introduce some funny conditionals to keep the
build
andhost
compiler_options
in the native case. In the future, I'd like to change the interpretation of command line options soThe logic is cross-agnostic, i.e. there are no conditions affected by
is_cross_build()
.Compiler args for both the build and host machines can always be
controlled by the command line.
Compiler args for both machines can always be controlled separately.