Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go through coreutils.compiler_options.{build.host.target} #4626

Merged
merged 2 commits into from
Feb 4, 2019

Commits on Feb 1, 2019

  1. C# and Java compilers should have is_cross = False

    All compilers should define this attribute. Probably should change base
    class to require this.
    Ericson2314 committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    6dbe33d View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2019

  1. Never access environment.properties downstream

    Instead use coredata.compiler_options.<machine>. This brings the cross
    and native code paths closer together, since both now use that.
    
    Command line options are interpreted just as before, for backwards
    compatibility. This does introduce some funny conditionals. In the
    future, I'd like to change the interpretation of command line options so
    
     - The logic is cross-agnostic, i.e. there are no conditions affected by
       `is_cross_build()`.
    
     - Compiler args for both the build and host machines can always be
       controlled by the command line.
    
     - Compiler args for both machines can always be controlled separately.
    Ericson2314 committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    19f81d3 View commit details
    Browse the repository at this point in the history