Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 add iPXE TLS support to local ironic deployment #1326

Merged
merged 1 commit into from
Feb 2, 2024
Merged

🌱 add iPXE TLS support to local ironic deployment #1326

merged 1 commit into from
Feb 2, 2024

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Aug 9, 2023 •
edited
Loading

This change will introduce the configuration options necessary to run locally deployed (local container no K8s) Ironic with customized TLS enabled iPXE.

Currently the custom iPXE firmware is being produced in the metal3-dev-env when this feature is enabled.

This PR should not cause any issue if merged, but the feature supported in this PR will become available only after metal3-io/ironic-image#429 is merged.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 9, 2023
@metal3-io metal3-io deleted a comment from metal3-io-bot Aug 9, 2023
@Rozzii
Copy link
Member Author

Rozzii commented Aug 9, 2023

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@Rozzii
Copy link
Member Author

Rozzii commented Aug 9, 2023

/test-centos-e2e-integration-main

@Rozzii
Copy link
Member Author

Rozzii commented Aug 9, 2023

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

tuminoid
tuminoid reviewed Aug 11, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just future TODO item noted.

tools/run_local_ironic.sh Show resolved Hide resolved
lentzi90
lentzi90 reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@tuminoid
Copy link
Member

tuminoid commented Sep 1, 2023

/hold
until metal3-io/ironic-image#429 is merged, since order matters.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2023
@Rozzii Rozzii changed the title 🌱 add iPXE TLS support to local ironic deployment WIP 🌱 add iPXE TLS support to local ironic deployment Sep 28, 2023
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2023
@Rozzii Rozzii mentioned this pull request Oct 12, 2023
Closed
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@Rozzii
Copy link
Member Author

Rozzii commented Oct 17, 2023

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@Rozzii Rozzii changed the title WIP 🌱 add iPXE TLS support to local ironic deployment 🌱 add iPXE TLS support to local ironic deployment Oct 17, 2023
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2023
@Rozzii
Copy link
Member Author

Rozzii commented Oct 17, 2023

/cc @dtantsur @elfosardo @zaneb

lentzi90
lentzi90 reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
tuminoid
tuminoid reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits (ignore at will).

As stated in earlier comment, we should also refactor the way args are passed, but in some other PR.

tools/run_local_ironic.sh Outdated Show resolved Hide resolved
tools/run_local_ironic.sh Outdated Show resolved Hide resolved
tools/run_local_ironic.sh Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@lentzi90
Copy link
Member

/test-ubuntu-integration-main

1 similar comment
@Rozzii
Copy link
Member Author

Rozzii commented Jan 18, 2024

/test-ubuntu-integration-main

@Rozzii
Copy link
Member Author

Rozzii commented Jan 18, 2024 •
edited
Loading

I will check the logs of test-ubuntu-integration-main soon, it is strange that now this is failing, it has passed multiple times before.

@Rozzii
Copy link
Member Author

Rozzii commented Jan 25, 2024

/test-ubuntu-integration-main
/metal3-bmo-e2e-test-pull

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Jan 29, 2024

/keep-test-ubuntu-integration-main

@Rozzii
Copy link
Member Author

Rozzii commented Jan 29, 2024 •
edited
Loading

/metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main
/test-ubuntu-integration-main
keep test was failing because broken pipe (related to ssh issues in infra)

For some reason ipxe certs are getting mounted, I am debugging , probably some bash condition mixup.

@Rozzii
Copy link
Member Author

Rozzii commented Jan 29, 2024

/metal3-bmo-e2e-test-pull

@Rozzii
Copy link
Member Author

Rozzii commented Jan 29, 2024

/override keep-test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@Rozzii: Overrode contexts on behalf of Rozzii: keep-test-ubuntu-integration-main

In response to this:

/override keep-test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2024
@Rozzii
add iPXE TLS support to local ironic deployment
eb638fc 
This change will introduce the configuration options necessary
to run locally deployed (local container no K8s) Ironic with
customized TLS enabled iPXE.

Currently the custom iPXE firmware is being produced in the
metal3-dev-env when this feature is enabled.

Conditions managing the passing of certificates to containers
have been modified in the run_local_ironic.sh to evaluate the
availibilty of the certificates instead of the acailability of the
related environment variables.

Signed-off-by: Adam Rozman <[email protected]>
@Rozzii
Copy link
Member Author

Rozzii commented Feb 1, 2024

/retest

@Rozzii
Copy link
Member Author

Rozzii commented Feb 1, 2024

/metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@Rozzii
Copy link
Member Author

Rozzii commented Feb 1, 2024

/metal3-bmo-e2e-test-pull

@Rozzii
Copy link
Member Author

Rozzii commented Feb 1, 2024

/test metal3-bmo-e2e-test-pull

@Rozzii
Copy link
Member Author

Rozzii commented Feb 1, 2024

/metal3-bmo-e2e-test-pull

@Rozzii
Copy link
Member Author

Rozzii commented Feb 1, 2024

/test metal3-bmo-e2e-test-pull

@Rozzii
Copy link
Member Author

Rozzii commented Feb 1, 2024

first this has to get merged to get through this PR through the CI metal3-io/metal3-dev-env#1344

@Rozzii
Copy link
Member Author

Rozzii commented Feb 2, 2024

/test-ubuntu-integration-main

1 similar comment
@Rozzii
Copy link
Member Author

Rozzii commented Feb 2, 2024

/test-ubuntu-integration-main

tuminoid
tuminoid reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
@metal3-io-bot metal3-io-bot merged commit be630fd into metal3-io:main Feb 2, 2024
21 checks passed
@metal3-io-bot metal3-io-bot deleted the iPXE_tls_runlocal branch February 2, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@zaneb zaneb Awaiting requested review from zaneb

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rozzii @tuminoid @dtantsur @metal3-io-bot @lentzi90 @elfosardo