Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync iPXE TLS certificate generation with firmware building #1344

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Jan 31, 2024

This commit :

  • Aligns the TLS certificate generation for the iPXE firmware with firmware building process
  • Changes the ironic_tls_setup script to be aligned with the google bash style guide

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Jan 31, 2024

/test-centos-integration-release-1-6
/test-ubuntu-e2e-integration-main

@Rozzii
Copy link
Member Author

Rozzii commented Feb 1, 2024

/test-centos-integration-release-1-6
/test-ubuntu-e2e-integration-main

@Rozzii
Copy link
Member Author

Rozzii commented Feb 1, 2024

/test-centos-integration-release-1-6
/test-ubuntu-e2e-integration-main

lib/ironic_tls_setup.sh Outdated Show resolved Hide resolved
This commit :

- Aligns the TLS certificate generation for the iPXE firmware
  with firmware building process
- Changes the ironic_tls_setup script to be aligned
  with the google bash style guide.

Signed-off-by: Adam Rozman <[email protected]>
@Rozzii
Copy link
Member Author

Rozzii commented Feb 1, 2024

/test-centos-integration-release-1-6
/test-ubuntu-e2e-integration-main

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for the tests to pass.

@Rozzii
Copy link
Member Author

Rozzii commented Feb 2, 2024

/cc @dtantsur @elfosardo

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
@metal3-io-bot metal3-io-bot merged commit a9dadb5 into metal3-io:main Feb 2, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the ipxe_tls_cert branch February 2, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants