-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync iPXE TLS certificate generation with firmware building #1344
Conversation
/test-centos-integration-release-1-6 |
/test-centos-integration-release-1-6 |
/test-centos-integration-release-1-6 |
This commit : - Aligns the TLS certificate generation for the iPXE firmware with firmware building process - Changes the ironic_tls_setup script to be aligned with the google bash style guide. Signed-off-by: Adam Rozman <[email protected]>
/test-centos-integration-release-1-6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's wait for the tests to pass.
/cc @dtantsur @elfosardo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This commit :