-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump github.com/onsi/ginkgo/v2 from 2.13.2 to 2.14.0 in /test #1402
🌱 Bump github.com/onsi/ginkgo/v2 from 2.13.2 to 2.14.0 in /test #1402
Conversation
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.13.2 to 2.14.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.13.2...v2.14.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test-centos-e2e-integration-main |
Dependabot tries to bump ginkgo in metal3-io#1401, metal3-io#1402, but separately, which causes our Makefile "e2e-tests" go haywire as it tries to read GINKGO_VER from wrong go.mod file, if they're bumped separately. Signed-off-by: Tuomo Tanskanen <[email protected]>
/hold |
Dependabot tries to bump ginkgo in metal3-io#1401, metal3-io#1402, but the ginkgo is actually missing from the hack/tools go.mod and those then fail when "go get ..." is run and it dirties the go.mod/go.sum in hack/tools. Kustomize build then fails on the dirty go.sum file. Added the ginkgo to hack/tools/go.mod as well. Signed-off-by: Tuomo Tanskanen <[email protected]>
Looks like github.com/onsi/ginkgo/v2 is up-to-date now, so this is no longer needed. |
Bumps github.com/onsi/ginkgo/v2 from 2.13.2 to 2.14.0.
Release notes
Sourced from github.com/onsi/ginkgo/v2's releases.
Changelog
Sourced from github.com/onsi/ginkgo/v2's changelog.
Commits
beaf16d
v2.14.04a2c832
add GinkgoTB() to docs92b6744
Add GinkgoTB() function (#1333)beb9507
Fix typo in internal/suite.go (#1332)65ec56d
Introduce DescribeTableSubtree4ac3a13
Fix typo in docs/index.md (#1319)465a8ec
Bump golang.org/x/tools from 0.16.0 to 0.16.1 (#1316)eab0e40
Bump actions/setup-go from 4 to 5 (#1313)fbf9724
Bump github/codeql-action from 2 to 3 (#1317)3ee80ee
Bump golang.org/x/crypto (#1318)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions