Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump github.com/onsi/ginkgo/v2 from 2.13.2 to 2.14.0 in /test #1402

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 15, 2024

Bumps github.com/onsi/ginkgo/v2 from 2.13.2 to 2.14.0.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.14.0

2.14.0

Features

You can now use GinkgoTB() when you need an instance of testing.TB to pass to a library.

Prior to this release table testing only supported generating individual Its for each test entry. DescribeTableSubtree extends table testing support to entire testing subtrees - under the hood DescrieTableSubtree generates a new container for each entry and invokes your function to fill our the container. See the docs to learn more.

  • Introduce DescribeTableSubtree [65ec56d]
  • add GinkgoTB() to docs [4a2c832]
  • Add GinkgoTB() function (#1333) [92b6744]

Fixes

  • Fix typo in internal/suite.go (#1332) [beb9507]
  • Fix typo in docs/index.md (#1319) [4ac3a13]
  • allow wasm to compile with ginkgo present (#1311) [b2e5bc5]

Maintenance

  • Bump golang.org/x/tools from 0.16.0 to 0.16.1 (#1316) [465a8ec]
  • Bump actions/setup-go from 4 to 5 (#1313) [eab0e40]
  • Bump github/codeql-action from 2 to 3 (#1317) [fbf9724]
  • Bump golang.org/x/crypto (#1318) [3ee80ee]
  • Bump golang.org/x/tools from 0.14.0 to 0.16.0 (#1306) [123e1d5]
  • Bump github.com/onsi/gomega from 1.29.0 to 1.30.0 (#1297) [558f6e0]
  • Bump golang.org/x/net from 0.17.0 to 0.19.0 (#1307) [84ff7f3]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.14.0

Features

You can now use GinkgoTB() when you need an instance of testing.TB to pass to a library.

Prior to this release table testing only supported generating individual Its for each test entry. DescribeTableSubtree extends table testing support to entire testing subtrees - under the hood DescrieTableSubtree generates a new container for each entry and invokes your function to fill our the container. See the docs to learn more.

  • Introduce DescribeTableSubtree [65ec56d]
  • add GinkgoTB() to docs [4a2c832]
  • Add GinkgoTB() function (#1333) [92b6744]

Fixes

  • Fix typo in internal/suite.go (#1332) [beb9507]
  • Fix typo in docs/index.md (#1319) [4ac3a13]
  • allow wasm to compile with ginkgo present (#1311) [b2e5bc5]

Maintenance

  • Bump golang.org/x/tools from 0.16.0 to 0.16.1 (#1316) [465a8ec]
  • Bump actions/setup-go from 4 to 5 (#1313) [eab0e40]
  • Bump github/codeql-action from 2 to 3 (#1317) [fbf9724]
  • Bump golang.org/x/crypto (#1318) [3ee80ee]
  • Bump golang.org/x/tools from 0.14.0 to 0.16.0 (#1306) [123e1d5]
  • Bump github.com/onsi/gomega from 1.29.0 to 1.30.0 (#1297) [558f6e0]
  • Bump golang.org/x/net from 0.17.0 to 0.19.0 (#1307) [84ff7f3]
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.13.2 to 2.14.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.13.2...v2.14.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added kind/dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jan 15, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furkatgofurov7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 15, 2024
@metal3-io-bot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 15, 2024
@tuminoid
Copy link
Member

/ok-to-test

@tuminoid
Copy link
Member

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2024
tuminoid added a commit to Nordix/cluster-api-provider-metal3 that referenced this pull request Jan 16, 2024
Dependabot tries to bump ginkgo in metal3-io#1401, metal3-io#1402, but separately, which
causes our Makefile "e2e-tests" go haywire as it tries to read
GINKGO_VER from wrong go.mod file, if they're bumped separately.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid
Copy link
Member

/hold
Our makefile explodes if ginkgo in root and test are bumped separately, so created #1403 to do both in the same.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2024
tuminoid added a commit to Nordix/cluster-api-provider-metal3 that referenced this pull request Jan 16, 2024
Dependabot tries to bump ginkgo in metal3-io#1401, metal3-io#1402, but the ginkgo is
actually missing from the hack/tools go.mod and those then fail
when "go get ..." is run and it dirties the go.mod/go.sum in
hack/tools. Kustomize build then fails on the dirty go.sum file.

Added the ginkgo to hack/tools/go.mod as well.

Signed-off-by: Tuomo Tanskanen <[email protected]>
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 16, 2024

Looks like github.com/onsi/ginkgo/v2 is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Jan 16, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/test/github.com/onsi/ginkgo/v2-2.14.0 branch January 16, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. go Pull requests that update Go code kind/dependencies Pull requests that update a dependency file ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants