🌱 bump ginkgo to v2.14.0 #1403
Merged
🌱 bump ginkgo to v2.14.0 #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/M
This was referenced Jan 16, 2024
|
/test-centos-e2e-integration-main |
Dependabot tries to bump ginkgo in metal3-io#1401, metal3-io#1402, but the ginkgo is actually missing from the hack/tools go.mod and those then fail when "go get ..." is run and it dirties the go.mod/go.sum in hack/tools. Kustomize build then fails on the dirty go.sum file. Added the ginkgo to hack/tools/go.mod as well. Signed-off-by: Tuomo Tanskanen <[email protected]>
tuminoid
force-pushed
the
tuomo/bump-ginkgo
branch
from
d18ebb6
to
c22be70
Compare
|
/test-centos-e2e-integration-main |
1 similar comment
|
/test-centos-e2e-integration-main |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot tries to bump ginkgo in #1401, #1402, but separately, which causes our Makefile "e2e-tests" go haywire. Ginkgo is actually missing from hack/tools/go.mod, and when "go get ginkgo..." is run, it dirties the go.sum/go.mod and the next build for kustomize explode.
Thus, add ginkgo to hack/tools/go.mod as well.