🐛 Changing errors in pause annotation functions from terminal to transient #1765
Conversation
Signed-off-by: adil ghaffar <[email protected]>
metal3-io-bot
added
the
size/S
adilGhaffarDev
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboukhalfa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/cherry-pick release-1.7 |
|
@mboukhalfa: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test metal3-ubuntu-e2e-integration-test-main |
|
/override metal3-centos-e2e-integration-test-main |
|
@mboukhalfa: Overrode contexts on behalf of mboukhalfa: metal3-centos-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mboukhalfa: new pull request created: #1766 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a bug and it is a followup of metal3-io#1765. According to https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/cluster.md, https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/control-plane.md and https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/machine-pool.md once failureReason or failureMessage surface on the CAPI object who is referencing the infra object, they cannot be restored anymore. Hence, CAPM3 should not clear them as well. Signed-off-by: Kashif Khan <[email protected]>
This is a bug and it is a followup of metal3-io#1765. According to https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/cluster.md, https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/control-plane.md and https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/machine-pool.md once failureReason or failureMessage surface on the CAPI object who is referencing the infra object, they cannot be restored anymore. Hence, CAPM3 should not clear them as well. Signed-off-by: Kashif Khan <[email protected]>
This is a bug and it is a followup of metal3-io#1765. According to https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/cluster.md, https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/control-plane.md and https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/machine-pool.md once failureReason or failureMessage surface on the CAPI object who is referencing the infra object, they cannot be restored anymore. Hence, CAPM3 should not clear them as well. Signed-off-by: Kashif Khan <[email protected]>
This is also a continuation of metal3-io#1765. Setting terminal error pushes CAPI machine to irrecoverable failed state. Hence we should throw a transient error and requeue here. Signed-off-by: Kashif Khan <[email protected]>
This is also a continuation of metal3-io#1765. Setting terminal error pushes CAPI machine to irrecoverable failed state. Hence we should throw a transient error and requeue here. Signed-off-by: Kashif Khan <[email protected]>
What this PR does / why we need it:
Changing errors in pause annotation functions from terminal to transient. When BMH is rebooted there is a chance we get a terminal error from these functions which can cause machines to be in a failed state.