🐛 Remove clearError() function for infrastructure objects #1767
Conversation
metal3-io-bot
added
the
size/M
kashifest
force-pushed
the
kashif/remove-clearError
branch
from
7b97ee3
to
bd1ed90
Compare
This is a bug and it is a followup of metal3-io#1765. According to https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/cluster.md, https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/control-plane.md and https://github.com/fabriziopandini/cluster-api/blob/main/docs/book/src/developer/architecture/controllers/machine-pool.md once failureReason or failureMessage surface on the CAPI object who is referencing the infra object, they cannot be restored anymore. Hence, CAPM3 should not clear them as well. Signed-off-by: Kashif Khan <[email protected]>
kashifest
force-pushed
the
kashif/remove-clearError
branch
from
bd1ed90
to
7b63f48
Compare
|
/test metal3-ubuntu-e2e-integration-test-main |
|
/test ? |
|
@kashifest: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override metal3-centos-e2e-integration-test-main |
|
@kashifest: Overrode contexts on behalf of kashifest: metal3-centos-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override metal3-centos-e2e-integration-test-main |
|
@kashifest: Overrode contexts on behalf of kashifest: metal3-centos-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
can we change this |
Ah ok, I thought we did that already ! |
I only changed errors in SetPause and RemovePause yesterday, didn't want to break anything. |
This is also a continuation of metal3-io#1765. Setting terminal error pushes CAPI machine to irrecoverable failed state. Hence we should throw a transient error and requeue here. Signed-off-by: Kashif Khan <[email protected]>
kashifest
force-pushed
the
kashif/remove-clearError
branch
from
338ae56
to
5cb7c53
Compare
|
/test metal3-ubuntu-e2e-integration-test-main |
|
@kashifest: Overrode contexts on behalf of kashifest: metal3-centos-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
/approve
LGTM from my side. @mboukhalfa please take a look.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adilGhaffarDev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
This is a bug and it is a followup of #1765.
According to
once
failureReasonorfailureMessagesurface on the CAPI object who is referencing the infra object, they cannot be restored anymore. Hence, CAPM3 should not clear them as well.For the same reason, this PR is removing one of the occurrences of setError so as not to through terminal error while associating BMH but through transient error.
Signed-off-by: Kashif Khan [email protected]