Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump golang to v1.22 #1852

Merged
merged 1 commit into from
Jul 25, 2024
Merged

🌱 Bump golang to v1.22 #1852

merged 1 commit into from
Jul 25, 2024

Conversation

NymanRobin
Copy link
Member

@NymanRobin NymanRobin commented Jul 22, 2024 •
edited
Loading

This bump is done since golang version v1.21 will be deprecated in August.

Fixes #1828

@NymanRobin
Bump golang to v1.22
e5e1cab 
This bump is done since golang version v1.21 will
deprecated in August.

Signed-off-by: NymanRobin <[email protected]>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2024
@NymanRobin NymanRobin mentioned this pull request Jul 22, 2024
Merged
@NymanRobin
Copy link
Member Author

Seems like a Prow config update is needed first! The PR for prow config update can be found here: metal3-io/project-infra#821

@smoshiur1237 do I remember correctly that the configuration has still to be applied manually after the PR merges on project-infra side?

@smoshiur1237
Copy link
Member

Seems like a Prow config update is needed first! The PR for prow config update can be found here: metal3-io/project-infra#821

@smoshiur1237 do I remember correctly that the configuration has still to be applied manually after the PR merges on project-infra side?

I think after we have changed the config in project-infra, we need to apply it manually in PROW.

@NymanRobin
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@NymanRobin: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-release-1-7
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-release-1-7
  • /test metal3-centos-e2e-feature-test-release-1-7-features
  • /test metal3-centos-e2e-feature-test-release-1-7-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-7-remediation
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-7
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-7
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-7
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-7
  • /test metal3-ubuntu-e2e-basic-test-release-1-7
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-remediation
  • /test metal3-ubuntu-e2e-integration-test-release-1-7

Use /test all to run the following jobs that were automatically triggered:

  • build
  • generate
  • gomod
  • manifestlint
  • shellcheck
  • test
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@NymanRobin
Copy link
Member Author

/test generate

@smoshiur1237
Copy link
Member

/test ?

@metal3-io-bot
Copy link
Contributor

@smoshiur1237: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-release-1-7
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-release-1-7
  • /test metal3-centos-e2e-feature-test-release-1-7-features
  • /test metal3-centos-e2e-feature-test-release-1-7-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-7-remediation
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-7
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-7
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-7
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-7
  • /test metal3-ubuntu-e2e-basic-test-release-1-7
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-remediation
  • /test metal3-ubuntu-e2e-integration-test-release-1-7

Use /test all to run the following jobs that were automatically triggered:

  • build
  • generate
  • gomod
  • manifestlint
  • shellcheck
  • test
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@smoshiur1237
Copy link
Member

/retest

@NymanRobin
Copy link
Member Author

/test unit

@NymanRobin
Copy link
Member Author

/retest

@smoshiur1237
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-7

smoshiur1237
smoshiur1237 reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2024
@metal3-io-bot metal3-io-bot merged commit d6a2166 into metal3-io:release-1.7 Jul 25, 2024
22 checks passed
@metal3-io-bot metal3-io-bot deleted the bump-golang-1.22-in-realse-1.7 branch July 25, 2024 10:22
@NymanRobin NymanRobin mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NymanRobin @smoshiur1237 @metal3-io-bot @adilGhaffarDev