Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prow config to test release 1.7 of capm3 with go v1.22 #821

Merged

Conversation

NymanRobin
Copy link
Member

Go 1.21 is deprecating in August and 1.7 release is still supported in capm3 so bump the go version in testing to be able to get the capm3 PR in.

It will say this is needed for the following PR: metal3-io/cluster-api-provider-metal3#1852

Since go v1.21 is deprecating in August 2024

Signed-off-by: NymanRobin <[email protected]>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2024
@NymanRobin NymanRobin force-pushed the move-capm3-1.7-testing-to-go-v1.22 branch from 9a988e6 to 6d5b8ac Compare July 22, 2024 10:27
@Rozzii
Copy link
Member

Rozzii commented Jul 23, 2024

/test metal3-ubuntu-e2e-integration-test-main

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@smoshiur1237
Copy link
Member

@Sunnatillo would you approve please?

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@metal3-io-bot metal3-io-bot merged commit cf43272 into metal3-io:main Jul 23, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator

@NymanRobin: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Go 1.21 is deprecating in August and 1.7 release is still supported in capm3 so bump the go version in testing to be able to get the capm3 PR in.

It will say this is needed for the following PR: metal3-io/cluster-api-provider-metal3#1852

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants