-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prow config to test release 1.7 of capm3 with go v1.22 #821
Update prow config to test release 1.7 of capm3 with go v1.22 #821
Conversation
Since go v1.21 is deprecating in August 2024 Signed-off-by: NymanRobin <[email protected]>
9a988e6
to
6d5b8ac
Compare
/test metal3-ubuntu-e2e-integration-test-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@Sunnatillo would you approve please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smoshiur1237, Sunnatillo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@NymanRobin: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Go 1.21 is deprecating in August and 1.7 release is still supported in capm3 so bump the go version in testing to be able to get the capm3 PR in.
It will say this is needed for the following PR: metal3-io/cluster-api-provider-metal3#1852