Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Install setup-envtest from controller-runtime release directly and Bump envtest version to v1.31.0 #1924

Merged
merged 2 commits into from
Aug 29, 2024
Merged

🌱 Install setup-envtest from controller-runtime release directly and Bump envtest version to v1.31.0 #1924

merged 2 commits into from
Aug 29, 2024

Conversation

kashifest
Copy link
Member

@kashifest kashifest commented Aug 28, 2024 •
edited
Loading

This PR changes the way to install setup-envtest from controller-runtime release directly instead of downloading it from go modules and also bumps the envtest kubernetes version to v1.31.0. Please check for kubernetes-sigs/controller-runtime#2811 for more information.

@kashifest
Bump envtest to v1.31.0
1b47b39 
Signed-off-by: Kashif Khan <[email protected]>
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2024
tuminoid
tuminoid reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit + can you add to description which problem this solves?

Makefile Outdated Show resolved Hide resolved
@kashifest
Install setup-envtest from controller-runtime release
bdb46d4 
This commit changes the way to install setup-envtest from controller-runtime release directly instead of downloading it from go modules
Signed-off-by: Kashif Khan <[email protected]>
@kashifest
Copy link
Member Author

kashifest commented Aug 28, 2024 •
edited
Loading

Nit + can you add to description which problem this solves?

Added the controller run-time PR in the description for better clarity

@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

tuminoid
tuminoid reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
@tuminoid
Copy link
Member

/retitle 🌱 Install setup-envtest from controller-runtime release directly and Bump envtest version to v1.31.0

@metal3-io-bot metal3-io-bot changed the title 🌱Install setup-envtest from controller-runtime release directly and Bump envtest version to v1.31.0 🌱 Install setup-envtest from controller-runtime release directly and Bump envtest version to v1.31.0 Aug 28, 2024
@kashifest
Copy link
Member Author

/cc @mboukhalfa

@kashifest
Copy link
Member Author

/cc @adilGhaffarDev @Sunnatillo @smoshiur1237

Sunnatillo
Sunnatillo approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sunnatillo
Sunnatillo reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
@metal3-io-bot metal3-io-bot merged commit e1fd00d into metal3-io:main Aug 29, 2024
23 checks passed
@metal3-io-bot metal3-io-bot deleted the kashif/bump-envtest-v1.31.x branch August 29, 2024 12:03
@tuminoid
Copy link
Member

/cherry-pick release-1.8

@metal3-io-bot metal3-io-bot mentioned this pull request Aug 29, 2024
Merged
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1935

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo approved these changes

@tuminoid tuminoid tuminoid left review comments

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kashifest @tuminoid @metal3-io-bot @Sunnatillo