Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Install setup-envtest from controller-runtime release directly and Bump envtest version to v1.31.0 #1935

Merged
merged 2 commits into from
Sep 3, 2024
Merged

🌱 Install setup-envtest from controller-runtime release directly and Bump envtest version to v1.31.0 #1935

merged 2 commits into from
Sep 3, 2024

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #1924

/assign tuminoid

@kashifest
Bump envtest to v1.31.0
bc3b0fa 
Signed-off-by: Kashif Khan <[email protected]>
@kashifest
Install setup-envtest from controller-runtime release
561a4e3 
This commit changes the way to install setup-envtest from controller-runtime release directly instead of downloading it from go modules
Signed-off-by: Kashif Khan <[email protected]>
@metal3-io-bot metal3-io-bot mentioned this pull request Aug 29, 2024
Merged
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2024
Sunnatillo
Sunnatillo reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@tuminoid
Copy link
Member

/retitle 🌱 Install setup-envtest from controller-runtime release directly and Bump envtest version to v1.31.0

@metal3-io-bot metal3-io-bot changed the title [release-1.8] 🌱 Install setup-envtest from controller-runtime release directly and Bump envtest version to v1.31.0 🌱 Install setup-envtest from controller-runtime release directly and Bump envtest version to v1.31.0 Aug 29, 2024
tuminoid
tuminoid reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
@tuminoid
Copy link
Member

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@tuminoid
Copy link
Member

/test ?

@metal3-io-bot
Copy link
Contributor Author

@tuminoid: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-release-1-8
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-release-1-8
  • /test metal3-centos-e2e-feature-test-release-1-8-features
  • /test metal3-centos-e2e-feature-test-release-1-8-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-8-remediation
  • /test metal3-e2e-1-29-1-30-upgrade-test-release-1-8
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-8
  • /test metal3-ubuntu-e2e-basic-test-release-1-8
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-remediation
  • /test metal3-ubuntu-e2e-integration-test-release-1-8

Use /test all to run the following jobs that were automatically triggered:

  • build
  • generate
  • gomod
  • manifestlint
  • shellcheck
  • test
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-8

Running it so I can set it as required

@tuminoid
Copy link
Member

OK, done. Unholding
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@kashifest
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-8

@tuminoid
Copy link
Member

tuminoid commented Sep 3, 2024

/retest

@metal3-io-bot metal3-io-bot merged commit 07d324b into metal3-io:release-1.8 Sep 3, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Sunnatillo Sunnatillo Sunnatillo left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

Assignees

@tuminoid tuminoid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metal3-io-bot @tuminoid @kashifest @Sunnatillo