-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add wf to automatically build controller image #50
base: main
Are you sure you want to change the base?
🌱 Add wf to automatically build controller image #50
Conversation
Signed-off-by: Huy Mai <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't postfix any other image with controller
either. IMO we shouldn't do that here either.
- 'v*' | ||
|
||
jobs: | ||
build_controller: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we expecting to have many jobs here? If not, then I'd probably not use controller in naming, but operator, or ISO (like IPAM) as more descriptive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there might be more images coming, based on what I found on the Makefile. IMO operator
is not more descriptive though, ISO might be, but it's not yet a familiar acronym yet, at least for me. controller
is, therefore, more suitable, as anyone could understand what it builds from the name. This is anyway just the name of the job, not the image name.
if: github.repository == 'metal3-io/ironic-standalone-operator' | ||
uses: metal3-io/project-infra/.github/workflows/container-image-build.yml@main | ||
with: | ||
image-name: 'ironic-standalone-operator/controller' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, and I'm not even sure we actually want to have it named like that, but just ironic-standalone-operator
or even ironic-standalone-operator-controller
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following the naming convention in Makefile
. Afaik there's at least bundle image, although the Dockerfile for it is nowhere to be found. But I agree ironic-standalone-operator-controller
would be a good name.
@dtantsur Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makefile is basically auto-generated. I'd definitely use just ironic-standalone-operator to be consistent with baremetal-operator.
@dtantsur you asked for workflow to build the images, would you mind taking a look and weighting in on job naming? |
This PR adds support for automatic container image build. Whenever a new PR is merged into
main
or one of the release branches, and whenever a newv*
tag is created, a new container image is built and pushed toquay.io/metal3-io
, with suitable tags applied.